Repository navigation
UI: Show a label instead of a broken link for hidden assets - #75178
Merged
bbovenzi merged 1 commit intoOct 20, 2026
Merged
Conversation
`next_run_assets` blanks the name and id of an asset leaf the caller may not read and marks it `hidden`, keeping the shape of the schedule without revealing which asset it waits on. The asset schedule popover did not know about that flag, so a redacted leaf rendered as a link with no text pointing at `/assets/null`. Only deployments whose auth manager authorizes assets individually reach this: FAB and the simple auth manager grant every asset id, so nothing is redacted there.
henry3260
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 20, 2026 02:48
boring-cyborg
Bot
added
area:translations
area:UI
1 task done
bbovenzi
approved these changes
Oct 20, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
henry3260
added a commit
that referenced
this pull request
Oct 21, 2026
…ts (#75178) (#75250) `next_run_assets` blanks the name and id of an asset leaf the caller may not read and marks it `hidden`, keeping the shape of the schedule without revealing which asset it waits on. The asset schedule popover did not know about that flag, so a redacted leaf rendered as a link with no text pointing at `/assets/null`. Only deployments whose auth manager authorizes assets individually reach this: FAB and the simple auth manager grant every asset id, so nothing is redacted there. (cherry picked from commit 4ca5754) Co-authored-by: Henry Chen <henrychen@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
next_run_assetsscopes the asset scheduling expression it serves to the caller: anassetleafwhose id is not readable keeps its place in the boolean tree, so the shape of the schedule stays
honest, but its
uri,nameandidare blanked andhiddenis set (#72864).The asset schedule popover never learned about that flag.
AssetNodetook every non-alias leaf downthe same path, so a redacted leaf rendered
<RouterLink to={/assets/${null}}>{null}</RouterLink>:a link with no visible text that navigates to
/assets/null. The REST API documentshiddenand thegenerated TypeScript client exposes it, so the contract existed on both sides — only the UI side of it
was missing.
Deployments whose auth manager authorizes assets individually are the ones affected. The FAB auth
manager returns every asset id and the simple auth manager grants all or nothing above the lowest
role, so nothing is redacted there.
What
airflow-core/src/airflow/ui/src/components/AssetExpression/AssetNode.tsx— deriveisHiddenfromthe leaf's
hiddenfield and give a hidden leaf its own branch: a lock icon and a mutedHidden assetlabel, with no link. Alias and readable-asset leaves render exactly as before.airflow-core/src/airflow/ui/public/i18n/locales/en/common.json— add theexpression.hiddenAssetkey. Other locales fall back to English until translated.
airflow-core/src/airflow/ui/src/components/AssetExpression/AssetNode.test.tsx— new test thatrenders a readable leaf and a hidden leaf together, asserting the hidden one is labelled and
contributes no link while the readable one keeps its
/assets/1link. It fails againstmainandpasses with this change.
related: #72864
Was generative AI tooling used to co-author this PR?