Skip to content

Make Dags sidebar button a link and move Dag Runs and Task Instances to Browse - #75422

Merged
bbovenzi merged 1 commit into
apache:mainfrom
stephenyang0215:ui-dags-nav-click-navigates
Oct 23, 2026
Merged

bbovenzi merged 1 commit into
apache:mainfrom
stephenyang0215:ui-dags-nav-click-navigates

Conversation

@stephenyang0215

@stephenyang0215 stephenyang0215 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

The Dags sidebar button opened a hover menu, so clicking it never reached the Dags page (#75407).

What changed
Following the discussion here, the Dags button is now a plain link to /dags, and Dag Runs and Task Instances are listed in the Browse menu. Both entries follow the Dags permission, since there is no separate menu item for them. The Browse button highlights on /dag_runs and /task_instances; the Dags button highlights on /dags and nested paths only.

Tests: updated DagsButton.test.tsx and added BrowseButton.test.tsx. Also checked in a local Breeze instance with example Dags.

closes: #75407

Before (recording from the issue, #75407):

681569994-34319ad3-d0ff-4c81-a1dc-662f6fe9bcae.mp4

After (this PR, local Breeze UI):

Screen.Recording.2026-10-23.at.12.09.06.PM.mov

Checked: full UI suite (pnpm test, 255 files, 2160 tests), eslint, prettier and tsc on the changed files, the prek hooks on commit, and clicking Dags, hovering over it and opening Browse in a local Breeze UI with example Dags. Keyboard and touch are not covered by the new tests and not tried in a browser.


Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Sonnet 5.5)

Generated-by: Claude Code (Sonnet 5.5) following the guidelines

@boring-cyborg

boring-cyborg Bot commented Oct 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bbovenzi

Copy link
Copy Markdown
Contributor

@pierrejeambrun I was worried that the hover change was going to confuse folks.

Maybe we just bring Dag Runs and Task Instances to be their own top level buttons instead of having the menu.

@jedcunningham

Copy link
Copy Markdown
Member

Or, put them in browse?

@kaxil

kaxil commented Oct 22, 2026

Copy link
Copy Markdown
Member

Or, put them in browse?

Yeah, browse is fine tbh

@kaxil kaxil added this to the Airflow 3.4.0 milestone Oct 22, 2026
@kaxil kaxil added the backport-to-v3-4-test Backport to v3-4-test label Oct 22, 2026
@stephenyang0215

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. I'm good to rework this PR along with these changes:

  1. make the Dags button a plain link to the dags list
  2. move Dag Runs and Task Instances into the browse menu.

Shall I go ahead and do that here?

@bbovenzi

Copy link
Copy Markdown
Contributor

Yes, let's do browse

@stephenyang0215
stephenyang0215 force-pushed the ui-dags-nav-click-navigates branch from b0bb34a to d41a7c8 Compare October 23, 2026 15:55
…to Browse

The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission.
@stephenyang0215 stephenyang0215 changed the title UI: Navigate to the Dags list on mouse click of the Dags nav button Make Dags sidebar button a link and move Dag Runs and Task Instances to Browse Oct 23, 2026
@bbovenzi
bbovenzi merged commit b9c657b into apache:main Oct 23, 2026
80 of 94 checks passed
@boring-cyborg

boring-cyborg Bot commented Oct 23, 2026

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

vatsrahul1001 pushed a commit that referenced this pull request Oct 24, 2026
…k Instances to Browse (#75422)

The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission.
(cherry picked from commit b9c657b)

Co-authored-by: Stephen Yang <stephenyang0215@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 24, 2026
…k Instances to Browse (#75422) (#75517)

The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission.
(cherry picked from commit b9c657b)

Co-authored-by: Stephen Yang <stephenyang0215@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-4-test Backport to v3-4-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dags button click does not lead to Dags page

4 participants