Repository navigation
Make Dags sidebar button a link and move Dag Runs and Task Instances to Browse - #75422
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
|
@pierrejeambrun I was worried that the hover change was going to confuse folks. Maybe we just bring Dag Runs and Task Instances to be their own top level buttons instead of having the menu. |
|
Or, put them in browse? |
Yeah, browse is fine tbh |
|
Thanks for the feedback. I'm good to rework this PR along with these changes:
Shall I go ahead and do that here? |
|
Yes, let's do browse |
b0bb34a to
d41a7c8
Compare
…to Browse The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission.
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
…k Instances to Browse (#75422) The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission. (cherry picked from commit b9c657b) Co-authored-by: Stephen Yang <stephenyang0215@gmail.com>
…k Instances to Browse (#75422) (#75517) The Dags button opened a hover menu, so clicking it never reached the Dags page. Make it a plain link to /dags and list Dag Runs and Task Instances in the Browse menu, gated by the Dags permission. (cherry picked from commit b9c657b) Co-authored-by: Stephen Yang <stephenyang0215@gmail.com>
The Dags sidebar button opened a hover menu, so clicking it never reached the Dags page (#75407).
What changed
Following the discussion here, the Dags button is now a plain link to /dags, and Dag Runs and Task Instances are listed in the Browse menu. Both entries follow the Dags permission, since there is no separate menu item for them. The Browse button highlights on /dag_runs and /task_instances; the Dags button highlights on /dags and nested paths only.
Tests: updated DagsButton.test.tsx and added BrowseButton.test.tsx. Also checked in a local Breeze instance with example Dags.
closes: #75407
Before (recording from the issue, #75407):
681569994-34319ad3-d0ff-4c81-a1dc-662f6fe9bcae.mp4
After (this PR, local Breeze UI):
Screen.Recording.2026-10-23.at.12.09.06.PM.mov
Checked: full UI suite (pnpm test, 255 files, 2160 tests), eslint, prettier and tsc on the changed files, the prek hooks on commit, and clicking Dags, hovering over it and opening Browse in a local Breeze UI with example Dags. Keyboard and touch are not covered by the new tests and not tried in a browser.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Sonnet 5.5) following the guidelines