Skip to content

TS SDK: Reject a blank queue in Dag and task specs - #75573

Merged
jason810496 merged 1 commit into
apache:mainfrom
guan404ming:ts-sdk-reject-blank-queue
Oct 25, 2026
Merged

jason810496 merged 1 commit into
apache:mainfrom
guan404ming:ts-sdk-reject-blank-queue

Conversation

@guan404ming

Copy link
Copy Markdown
Member

Related

Why

  • A blank Dag or task queue passes parsing and reaches the scheduler as is
  • No queue_to_coordinator entry matches it, so the tasks never reach the Node.js coordinator

How

  • Reject a blank queue in the Dag spec and in each task spec when the Dag is defined
  • An unset queue still works at both levels, as in the Java SDK
  • Say in the TypeScript guide that a set queue cannot be blank

Was generative AI tooling used to co-author this PR?

@guan404ming
guan404ming force-pushed the ts-sdk-reject-blank-queue branch from 4634973 to 8db71f9 Compare October 24, 2026 18:26
@guan404ming
guan404ming marked this pull request as ready for review October 25, 2026 07:11

@jason810496 jason810496 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hardening.

@jason810496 jason810496 added the backport-to-v3-4-test Backport to v3-4-test label Oct 25, 2026
@jason810496 jason810496 added this to the Airflow 3.4.0 milestone Oct 25, 2026
@jason810496
jason810496 enabled auto-merge (squash) October 25, 2026 07:39
@jason810496
jason810496 merged commit 054d093 into apache:main Oct 25, 2026
156 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Backport successfully created: v3-4-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-4-test PR Link

github-actions Bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 25, 2026
…e#75573)

(cherry picked from commit 054d093)

Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
aws-airflow-bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 25, 2026
…e#75573)

(cherry picked from commit 054d093)

Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 26, 2026
(cherry picked from commit 054d093)

Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
vatsrahul1001 pushed a commit that referenced this pull request Oct 26, 2026
… (#75605)

(cherry picked from commit 054d093)

Co-authored-by: Guan-Ming Chiu <105915352+guan404ming@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants