Repository navigation
[v3-4-test] Fix scheduler crash when retrying a task that timed out or was killed externally (#75472) - #75582
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:Executors-core
vatsrahul1001
marked this pull request as ready for review
October 25, 2026 05:26
vatsrahul1001
requested review from
XD-DENG,
ashb,
dheerajturaga,
hussein-awala,
o-nikolas and
pierrejeambrun
as code owners
October 25, 2026 05:26
vatsrahul1001
enabled auto-merge (squash)
October 25, 2026 05:26
…r was killed externally (#75472) The database callback sink committed and closed the scheduler's scoped session when sending a callback, detaching the task instance the scheduler was about to retry. Archiving the attempt then wrote nothing, and inserting the next attempt hit the task_instance_current_key unique constraint, which stopped the scheduler. The sink now adds the request to the caller's session, and the scheduler commits it. The Dag-lookup-failure branch of executor event processing passes its session to set_state for the same reason. (cherry picked from commit 976c1d0) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
vatsrahul1001
force-pushed
the
backport-976c1d0-v3-4-test
branch
from
October 26, 2026 04:01
7b9ceeb to
c5a4fa8
Compare
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The database callback sink committed and closed the scheduler's scoped
session when sending a callback, detaching the task instance the
scheduler was about to retry. Archiving the attempt then wrote nothing,
and inserting the next attempt hit the task_instance_current_key unique
constraint, which stopped the scheduler.
The sink now adds the request to the caller's session, and the
scheduler commits it. The Dag-lookup-failure branch of executor event
processing passes its session to set_state for the same reason.
(cherry picked from commit 976c1d0)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com