Repository navigation
[v3-4-test] Fix "Dynamic require" error for CommonJS packages in airflow-ts-pack (#75067) - #75603
Merged
Merged
Conversation
…low-ts-pack (#75067) * Fix airflow-ts-pack for CommonJS packages using Node built-ins airflow-ts-pack outputs an ESM bundle, and an ESM file has no `require`. esbuild turns a CommonJS dependency's `require("fs")` into a shim that throws `Dynamic require of "fs" is not supported` unless a `require` is in scope. So any Dag importing such a package (yaml, pg, axios, @aws-sdk/client-s3, ...) failed to pack, and users cannot pass esbuild options to work around it. * Move the require banner comment onto the esbuild option (cherry picked from commit 8b2ef80) Co-authored-by: Andrew Chang <69671930+Andrushika@users.noreply.github.com>
1 task done
jason810496
marked this pull request as ready for review
October 25, 2026 07:56
jason810496
enabled auto-merge (squash)
October 25, 2026 07:56
jason810496
approved these changes
Oct 25, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
airflow-ts-pack outputs an ESM bundle, and an ESM file has no
require. esbuild turns a CommonJS dependency'srequire("fs")intoa shim that throws
Dynamic require of "fs" is not supportedunless arequireis in scope. So any Dag importing such a package (yaml, pg,axios, @aws-sdk/client-s3, ...) failed to pack, and users cannot pass
esbuild options to work around it.
(cherry picked from commit 8b2ef80)
Co-authored-by: Andrew Chang 69671930+Andrushika@users.noreply.github.com