Repository navigation
UI: Don't fire keyboard shortcuts while typing in a Monaco editor - #75684
Merged
bbovenzi merged 1 commit intoOct 27, 2026
Merged
Conversation
closes: apache#75661 Signed-off-by: Arnav Singh <arnavsingh08@outlook.com>
arnavsingh0418
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 26, 2026 18:25
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
ieCecchetti
approved these changes
Oct 26, 2026
bbovenzi
approved these changes
Oct 27, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
bbovenzi
pushed a commit
that referenced
this pull request
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #75661
Typing "g" in the Trigger Dag dialog's Configuration JSON field toggled the grid/graph view instead of entering the letter. The same happened for any other single-key shortcut typed into a Monaco editor.
Cause:
react-hotkeys-hookskips keys typed into form fields (input,textarea,select). Monaco 0.57 turns on itseditContextoption by default where the browser supports the EditContext API (Chrome, Edge). The element that takes input is then a plaindiv.native-edit-contextinstead of a hidden<textarea>, so the hotkey library no longer sees a form field. The grid/graph shortcut fires and itspreventDefaultswallows the key.Fix:
useShortcut, the wrapper every UI shortcut goes through, now passes anignoreEventWhenthat skips key events coming from inside a.monaco-editor. That restores the behavior from before EditContext, when Monaco's hidden<textarea>made the library skip these events. A caller's ownignoreEventWhenis still applied. The library keepsignoreEventWhenin a ref and leaves it out of its options comparison, so the listener is not re-bound on every render.Tests: two cases in
useShortcut.test.tsx:.monaco-editordoes not fire the shortcut, and the same key pressed elsewhere does. This test fails without the fix.ignoreEventWhenis still honored.Run in
airflow-core/src/airflow/ui:vitest run src/hooks/useShortcut.test.tsx: 6 passed.useShortcut(SearchBar,PanelButtons,Code,CallbackLogs,LogSearchInput,Logs) plususeShortcut: 7 files, 46 tests passed.eslintandprettier --checkon the changed files pass, andtsc --p tsconfig.app.jsonpasses.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.