Repository navigation
Wait for a maintainer when a fork PR changes any CI-defining file - #75718
Merged
Merged
Conversation
The project-CI rule of the workflow run auto-approval checked a shorter list of CI-defining paths than the fork CI reconciler. A PR changing a .pre-commit-config.yaml, which decides the static checks CI runs, had its runs approved without a maintainer's look. Changes to Dockerfile*, scripts/docker/ and scripts/in_container/ were held back only because selective checks currently run the full set of tests for them. Both rules now read the reconciler's list, so a path added there applies to both.
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
October 27, 2026 06:00
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-4-test
potiuk
approved these changes
Oct 27, 2026
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 27, 2026
…ing file (apache#75718) The project-CI rule of the workflow run auto-approval checked a shorter list of CI-defining paths than the fork CI reconciler. A PR changing a .pre-commit-config.yaml, which decides the static checks CI runs, had its runs approved without a maintainer's look. Changes to Dockerfile*, scripts/docker/ and scripts/in_container/ were held back only because selective checks currently run the full set of tests for them. Both rules now read the reconciler's list, so a path added there applies to both. (cherry picked from commit c79293e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 27, 2026
…ing file (#75718) The project-CI rule of the workflow run auto-approval checked a shorter list of CI-defining paths than the fork CI reconciler. A PR changing a .pre-commit-config.yaml, which decides the static checks CI runs, had its runs approved without a maintainer's look. Changes to Dockerfile*, scripts/docker/ and scripts/in_container/ were held back only because selective checks currently run the full set of tests for them. Both rules now read the reconciler's list, so a path added there applies to both. (cherry picked from commit c79293e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Oct 27, 2026
…ing file (#75718) (#75733) The project-CI rule of the workflow run auto-approval checked a shorter list of CI-defining paths than the fork CI reconciler. A PR changing a .pre-commit-config.yaml, which decides the static checks CI runs, had its runs approved without a maintainer's look. Changes to Dockerfile*, scripts/docker/ and scripts/in_container/ were held back only because selective checks currently run the full set of tests for them. Both rules now read the reconciler's list, so a path added there applies to both. (cherry picked from commit c79293e) Co-authored-by: Shahar Epstein <60007259+shahar1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As-titled, CI-defining files should be gated.
AI Summary
The workflow run auto-approval added in #75455 has two rules. A PR whose CI runs in the contributor's fork is held for a maintainer when it changes a file the fork CI reconciler counts as CI-defining. A PR whose CI runs in the project was checked against a shorter list:
.github/,dev/breeze/andscripts/ci/.Running the decision with real selective checks on main (54f645d) showed the effect:
.pre-commit-config.yamlhad its runs approved without a maintainer's look. This holds for the root file (estimated 274 job-minutes) and for nested ones such asairflow-core/.pre-commit-config.yaml(6 job-minutes). These files decide which static checks CI runs.Dockerfile*,scripts/docker/andscripts/in_container/were refused, but only because selective checks currently run the full set of tests for them. Narrowing that selective-checks rule would have let them through.This PR makes the project rule use the existing
find_fork_ci_definition_files. Both rules now read the reconciler's list, so a path added there applies to both. The docs that list the paths are updated.Not covered here, and the same for both rules: other files that CI runs, such as
scripts/tools/,devel-common/or nested Dockerfiles likeairflow-e2e-tests/docker/*. WideningCI_DEFINING_PREFIXESinfork_ci_reconcile.pywould cover both rules.Checks run locally:
test_decide_approvalfor.pre-commit-config.yaml,airflow-core/.pre-commit-config.yaml,Dockerfile.ci,scripts/docker/entrypoint_ci.shandscripts/in_container/run_ci_tests.sh. All five fail without the change.test_workflow_run_approval.pyandtest_fork_ci_reconcile.py: 321 passed.prekpre-commit and manual stages passed. Skipped:lychee-docker, because Docker was unavailable in the session.breeze verifycommands (fulldev/breezesuite and its integration tests): 23 failures intest_packages.py,test_selective_checks.py,test_shim_version_check.py,test_workflow_commands.pyand the reproducible-build integration test. The 22 non-integration ones fail the same way with this change reverted.test_publish_docs_to_s3.pycould not be collected locally (needsbotocore[crt]).related: #75455
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines