Repository navigation
[v3-4-test] Keep cancelled CI runs from showing a failed CI passed check (#75720) - #75738
Merged
Merged
Conversation
…eck (apache#75720) * Keep cancelled CI runs from showing a failed CI passed check The step meant to fail CI passed when a job hit its timeout tested `!cancelled()`. Inside the `always()` gate job, a step's `cancelled()` is false even when the run itself was cancelled, because the job starts after the cancellation. So every duplicate run that concurrency cancelled, and every run cancelled by hand, showed a failed "CI passed (run cancelled)" check next to the passing run of the same commit (runs 40442992585 and 40453574496). Only a job-level `if` sees that the run was cancelled, so the timeout check moves into a job of its own. A job that hits its timeout while the run goes on still fails the gate, which the scheduled canary's Slack report relies on, and the failed check is now the required CI passed instead of "CI passed (run cancelled)". * Check the timed-out-jobs needs only when that job exists Removing check-timed-out-jobs alone already fails the hook, because the gate still needs it. Requiring the job as well forced every existing test case to carry it. (cherry picked from commit 8eb5357)
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
October 27, 2026 09:40
potiuk
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #75720 to v3-4-test. The automatic backport failed, but the commit cherry-picks cleanly.
v3-4-test has the same
!cancelled()step from #75578 (backported in #75618), so cancelled duplicate runs show a failed "CI passed (run cancelled)" check there too. This moves the timeout check into thecheck-timed-out-jobsjob, same as on main.(cherry picked from commit 8eb5357)
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5.5 following the guidelines