Repository navigation
[v3-4-test] Stop a stale callback stat from forcing constant Dag file reparsing (#73433) - #75939
Merged
Merged
Conversation
… reparsing (apache#73433) * Stop a stale callback stat from forcing constant Dag file reparsing A callback pins bundle_version on its DagFileInfo while the bundle scan leaves it unset, so one file can hold two _file_stats entries. Collapsing them by presence_key with a dict comprehension keeps whichever was inserted last, which is the callback entry, and that entry is never refreshed afterwards because later parses write to the scan key. Its frozen last_finish_time makes the file look long unparsed, so min_file_process_interval never excludes it and the processor reparses it on every loop until it restarts. Resolve the collapse by the most recent parse instead. _sort_by_mtime and processed_recently share the same lookup, which previously disagreed with each other on which duplicate wins. * Prefer the bundle scan's stat when resolving a file's parse time Callback runs never record a parse of the current file: a callback-only stat has no last_finish_time, and a timed-out callback processor is stamped anyway. Fall back to a versioned stat only when the file has no scan entry. * Use only scan stats for queueing and parse metrics * Use a neutral name for the duplicate-entries test (cherry picked from commit 72628b5)
shahar1
enabled auto-merge (squash)
October 29, 2026 07:41
shahar1
disabled auto-merge
October 29, 2026 07:46
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #73433 to
v3-4-test. It carries thebackport-to-v3-4-testlabel and the 3.4.0 milestone, but the backport workflow never ran for it after the merge.A callback leaves a second, never-refreshed stat entry for a Dag file. That entry makes the file look long unparsed, so
min_file_process_intervalstops excluding it and the Dag processor reparses it on every loop until it restarts. Users hit this on 3.3.x in production (see the discussion on #73433).The cherry-pick of 72628b5 applies to
v3-4-testwithout conflicts.related: #73432
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines