ARTEMIS-6042 Improve ArtemisMBeanServerGuard.canInvoke implementation#6403
Draft
GChuf wants to merge 12 commits into
Draft
ARTEMIS-6042 Improve ArtemisMBeanServerGuard.canInvoke implementation#6403GChuf wants to merge 12 commits into
GChuf wants to merge 12 commits into
Conversation
jbertram
reviewed
Apr 30, 2026
Contributor
|
I had Claude create a JMH test for this and the results look promising, especially when /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.activemq.artemis.tests.performance.jmh;
import org.apache.activemq.artemis.core.server.management.ArtemisMBeanServerGuard;
import org.apache.activemq.artemis.core.server.management.JMXAccessControlList;
import org.apache.activemq.artemis.spi.core.security.jaas.RolePrincipal;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Warmup;
import javax.security.auth.Subject;
import java.security.PrivilegedAction;
import java.util.concurrent.ThreadLocalRandom;
@State(Scope.Benchmark)
@Fork(2)
@Warmup(iterations = 5, time = 1)
@Measurement(iterations = 8, time = 1)
@BenchmarkMode(Mode.Throughput)
public class MBeanServerGuardCanInvokePerfTest {
private ArtemisMBeanServerGuard guard;
private String[] objectNames;
private String[] operationNames;
private String[] operationNamesWithParams;
private String allowListedObjectName;
private Subject subjectWithViewRole;
private Subject subjectWithAmqRole;
private Subject subjectWithNoRole;
@Param({"10", "50", "100"})
int objectNameCount;
@Setup
public void init() {
guard = new ArtemisMBeanServerGuard();
JMXAccessControlList acl = JMXAccessControlList.createDefaultList();
guard.setJMXAccessControlList(acl);
// Create test object names from different domains
objectNames = new String[objectNameCount];
for (int i = 0; i < objectNameCount; i++) {
if (i % 3 == 0) {
objectNames[i] = "org.apache.activemq.artemis:broker=\"0.0.0.0\",component=addresses,address=\"address." + i + "\"";
} else if (i % 3 == 1) {
objectNames[i] = "org.apache.activemq.artemis:broker=\"0.0.0.0\",component=addresses,subcomponent=queues,routing-type=ANYCAST,name=\"queue-" + i + "\"";
} else {
objectNames[i] = "java.lang:type=Memory,name=HeapMemoryUsage-" + i;
}
}
// Allowlisted object name (hawtio domain is in the default allowlist)
allowListedObjectName = "hawtio:type=security,name=RBACRegistry";
// Common operation names
operationNames = new String[]{
"getMessageCount",
"listMessages",
"sendMessage",
"removeMessage",
"getConsumerCount",
"listConsumers",
"getAttribute",
"setAttribute",
"invoke"
};
// Operation names with parameter lists
operationNamesWithParams = new String[]{
"sendMessage(java.lang.String)",
"sendMessage(java.lang.String,java.lang.String)",
"removeMessage(long)",
"listMessages(java.lang.String)",
"setAttribute(java.lang.String,java.lang.Object)"
};
// Set up test subjects with different roles
subjectWithViewRole = new Subject();
subjectWithViewRole.getPrincipals().add(new RolePrincipal("view"));
subjectWithAmqRole = new Subject();
subjectWithAmqRole.getPrincipals().add(new RolePrincipal("amq"));
subjectWithNoRole = new Subject();
}
@Benchmark
public boolean testCanInvokeAllowListed() {
return guard.canInvoke(allowListedObjectName, "anyOperation");
}
@Benchmark
public boolean testCanInvokeWithViewRole() {
return Subject.doAs(subjectWithViewRole, (PrivilegedAction<Boolean>) () -> {
int idx = ThreadLocalRandom.current().nextInt(objectNames.length);
int opIdx = ThreadLocalRandom.current().nextInt(operationNames.length);
return guard.canInvoke(objectNames[idx], operationNames[opIdx]);
});
}
@Benchmark
public boolean testCanInvokeWithAmqRole() {
return Subject.doAs(subjectWithAmqRole, (PrivilegedAction<Boolean>) () -> {
int idx = ThreadLocalRandom.current().nextInt(objectNames.length);
int opIdx = ThreadLocalRandom.current().nextInt(operationNames.length);
return guard.canInvoke(objectNames[idx], operationNames[opIdx]);
});
}
@Benchmark
public boolean testCanInvokeWithNoRole() {
return Subject.doAs(subjectWithNoRole, (PrivilegedAction<Boolean>) () -> {
int idx = ThreadLocalRandom.current().nextInt(objectNames.length);
int opIdx = ThreadLocalRandom.current().nextInt(operationNames.length);
return guard.canInvoke(objectNames[idx], operationNames[opIdx]);
});
}
@Benchmark
public boolean testCanInvokeWithParameterStripping() {
return Subject.doAs(subjectWithViewRole, (PrivilegedAction<Boolean>) () -> {
int idx = ThreadLocalRandom.current().nextInt(objectNames.length);
int opIdx = ThreadLocalRandom.current().nextInt(operationNamesWithParams.length);
return guard.canInvoke(objectNames[idx], operationNamesWithParams[opIdx]);
});
}
@Benchmark
public boolean testCanInvokeNullOperation() {
return guard.canInvoke(objectNames[0], null);
}
@Benchmark
public boolean testCanInvokeInvalidObjectName() {
return guard.canInvoke("invalid:object:name:with:too:many:colons", "operation");
}
@Benchmark
public boolean testCanInvokeMixedScenarios() {
return Subject.doAs(subjectWithViewRole, (PrivilegedAction<Boolean>) () -> {
int scenario = ThreadLocalRandom.current().nextInt(4);
switch (scenario) {
case 0:
return guard.canInvoke(allowListedObjectName, "operation");
case 1:
int idx = ThreadLocalRandom.current().nextInt(objectNames.length);
int opIdx = ThreadLocalRandom.current().nextInt(operationNames.length);
return guard.canInvoke(objectNames[idx], operationNames[opIdx]);
case 2:
idx = ThreadLocalRandom.current().nextInt(objectNames.length);
opIdx = ThreadLocalRandom.current().nextInt(operationNamesWithParams.length);
return guard.canInvoke(objectNames[idx], operationNamesWithParams[opIdx]);
default:
return guard.canInvoke(objectNames[0], null);
}
});
}
} |
Contributor
Author
|
@jbertram thanks for the test you provided - I finally ran it yesterday (i didn't realise more than a month has passed) and the results seemed a bit strange to me - I expected to see bigger improvements. So I explained a couple of things to claude and after a couple of tries I got another test out of it, which should be closer to the "console scenario". In my case, though, some improvements can be seen in the tests you provided as well. Results: JBertram's tests "Console scenario" tests: I also tested gc with Putting just the gc.alloc.rate here: |
Contributor
Author
|
This is still a WIP, but I've put all tests into 1 file and added cache for object names in f0afa2c, and then changed from synchronized map to concurrent hash map in 3ceb8d1. @jbertram can you guys check and confirm if this is something you'd be willing to review and merge eventually? Results on my machine running java 21.0.2 (for objectNameCount 1000 where applicable) Throughput
GC allocation per op
|
Contributor
|
@GChuf I definitely think this is something we'd merge assuming all the commits were referencing a valid Jira. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.