Skip to content

[doc] Add explicit cast and add unit tests#553

Open
sean-g-rae wants to merge 4 commits into
apache:masterfrom
sean-g-rae:srae/add-unit-tests
Open

[doc] Add explicit cast and add unit tests#553
sean-g-rae wants to merge 4 commits into
apache:masterfrom
sean-g-rae:srae/add-unit-tests

Conversation

@sean-g-rae

Copy link
Copy Markdown

Thanks for your contribution to Apache Commons! Your help is appreciated!

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? I used Junie (Claude) to help create some of the test cases
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

@garydgregory garydgregory left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sean-g-rae

This PR needs work. You must make sure that when a change is made to a main class, a corresponding test class fails when the main changes are omitted.

For example, if I apply this PR locally and revert the changes to ColorGroup and run ColorGroupTest, the test is green. This obviously is bad and means that a regression is just waiting to happen.

TY!

@garydgregory

Copy link
Copy Markdown
Member

@sean-g-rae ping 🔔

What: Roll back the implicit cast, isolating this PR to just adding unit tests
Why: Change was not covered by unit tests, and didn't fit the rest of the PR scope
@sean-g-rae sean-g-rae requested a review from garydgregory June 24, 2026 03:11
@sean-g-rae

Copy link
Copy Markdown
Author

@sean-g-rae ping 🔔

Thanks for the feedback! To keep the PR focused, I reverted the non-test change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants