[doc] Add explicit cast and add unit tests#553
Open
sean-g-rae wants to merge 4 commits into
Open
Conversation
garydgregory
requested changes
Jun 21, 2026
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hello @sean-g-rae
This PR needs work. You must make sure that when a change is made to a main class, a corresponding test class fails when the main changes are omitted.
For example, if I apply this PR locally and revert the changes to ColorGroup and run ColorGroupTest, the test is green. This obviously is bad and means that a regression is just waiting to happen.
TY!
Member
|
@sean-g-rae ping 🔔 |
What: Roll back the implicit cast, isolating this PR to just adding unit tests Why: Change was not covered by unit tests, and didn't fit the rest of the PR scope
Author
Thanks for the feedback! To keep the PR focused, I reverted the non-test change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to Apache Commons! Your help is appreciated!
Before you push a pull request, review this list:
mvn; that'smvnon the command line by itself.