Skip to content

DeferredFileOutputStream better NPE message and new file permission tests#862

Merged
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/DeferredFileOutputStream_temp_file_ownership
Jun 21, 2026
Merged

DeferredFileOutputStream better NPE message and new file permission tests#862
garydgregory merged 1 commit into
apache:masterfrom
garydgregory:fix/DeferredFileOutputStream_temp_file_ownership

Conversation

@garydgregory

Copy link
Copy Markdown
Member
  • Add tests to validate owner permission on POSIX.
  • Refactor test to check a specific folder for POSIX instead of the default FS.
  • DeferredFileOutputStream.thresholdReached(): Throws an NPE with a useful message.
  • DeferredFileOutputStream.thresholdReached(): Better local variable name.

Before you push a pull request, review this list:

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.

- Add tests to validate owner permission on POSIX.
- Refactor test to check a specific folder for POSIX instead of the
default FS.
- DeferredFileOutputStream.thresholdReached(): Throws an NPE with a
useful message.
- DeferredFileOutputStream.thresholdReached(): Better local variable
name.
@garydgregory garydgregory force-pushed the fix/DeferredFileOutputStream_temp_file_ownership branch from f242b39 to f68152a Compare June 21, 2026 14:35
@garydgregory garydgregory changed the title DeferredFileOutputStream NPE clean up and new file permission tests DeferredFileOutputStream better NPE message and new file permission tests Jun 21, 2026
@garydgregory garydgregory merged commit 1179563 into apache:master Jun 21, 2026
24 checks passed
@garydgregory garydgregory deleted the fix/DeferredFileOutputStream_temp_file_ownership branch June 21, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant