Skip to content

perf(core): write one sort-shuffle file per task instead of one per input #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dandandan merged 2 commits into from
Aug 21, 2026
+372 −137
Merged

perf(core): write one sort-shuffle file per task instead of one per input #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52a511f
perf(core): write one sort-shuffle file per task instead of one per i…
Dandandan Aug 16, 2026
8165ddf
Merge branch 'main' into perf/consolidate-shuffle-files-per-task
Dandandan Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ballista/core/src/execution_plans/sort_shuffle/spill.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,19 @@ impl SpillManager {
work_dir: &str,
job_id: &JobId,
stage_id: usize,
task_id: usize,
input_partition: usize,
schema: SchemaRef,
compression: Option<CompressionType>,
) -> Result<Self> {
// Spills live beside the task's data file, one directory per input
// partition, so a task owns exactly one directory under the stage and
// `cleanup` leaves only `data.arrow` and its index behind.
let mut spill_dir = PathBuf::from(work_dir);
spill_dir.push(job_id.as_str());
spill_dir.push(format!("{stage_id}"));
spill_dir.push(format!("{input_partition}"));
spill_dir.push("spill");
spill_dir.push(format!("{task_id}"));
spill_dir.push(format!("spill-{input_partition}"));

std::fs::create_dir_all(&spill_dir).map_err(BallistaError::IoError)?;

Expand Down Expand Up @@ -279,6 +283,7 @@ mod tests {
&"job1".into(),
1,
0,
0,
schema.clone(),
Some(CompressionType::LZ4_FRAME),
)?;
Expand Down Expand Up @@ -314,6 +319,7 @@ mod tests {
&"job1".into(),
1,
0,
0,
schema.clone(),
Some(CompressionType::LZ4_FRAME),
)?;
Expand Down Expand Up @@ -351,6 +357,7 @@ mod tests {
&"job1".into(),
1,
0,
0,
schema.clone(),
Some(CompressionType::LZ4_FRAME),
)?;
Expand Down Expand Up @@ -397,6 +404,7 @@ mod tests {
&"job1".into(),
1,
0,
0,
schema.clone(),
Some(CompressionType::LZ4_FRAME),
)?;
Expand Down
Loading