Fail to parse - "select * from (table_name)"

[eyalleshem]

I think it's fail here - https://github.com/andygrove/sqlparser-rs/blob/master/src/parser.rs#L1797
because the code assume that inside the Parenthesis should be TableFactor::Derived or TableFactor::NestedJoin, but it's not take in account it's could be TableFactor::Table

[nickolay]

from (table_name) is not actually valid SQL. Note that <table primary> in the ANSI SQL grammar does not allow parentheses around <table or query name>. A quick test shows that at least MS SQL Server follows the spec here. What database are you working with?

[eyalleshem]

Thanks for the fast response :)

I tested against snowflake ..
Is that something that could be solve by building a dialect ?

[nickolay]

Theoretically, yes. Practically in the current implementation the selected dialect only affects the tokenizer, and the parser unconditionally tries to parse some non-standard constructs.

[eyalleshem]

So a code that support such syntax could be accepted?

[nickolay]

I guess so, if it's going to be a simple change, that doesn't introduce problems parsing the standard syntax (this specific bit of the parser is quite complex as it is). @benesch what do you think?

[eyalleshem]

well - i tried :)

[nickolay]

PR #155 is now merged, closing this. Thanks!