Support parsing SQL strings to Exprs#10995
Merged
Merged
Conversation
xinlifoobar
marked this pull request as draft
June 19, 2024 10:44
alamb
reviewed
Jun 19, 2024
xinlifoobar
marked this pull request as ready for review
June 20, 2024 07:13
Weijun-H
reviewed
Jun 20, 2024
xinlifoobar
commented
Jun 21, 2024
alamb
approved these changes
Jun 21, 2024
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
I think this looks great -- thank you so much @xinlifoobar
I have some suggestions that could make the examples / code easier to read, but they could be done as follow on PRs too. I think the code is really nice. Well done 🏆
cc @Omega359 @jiacai2050 @devinjdangelo @backkem and @Jefffrey as you expressed interest in #8736
xinlifoobar
force-pushed
the
dev/xinli/parse_sql
branch
from
June 22, 2024 14:00
4924acb to
578d198
Compare
github-actions
Bot
added
logical-expr
xinlifoobar
force-pushed
the
dev/xinli/parse_sql
branch
from
June 22, 2024 14:02
578d198 to
b220130
Compare
xinlifoobar
marked this pull request as draft
June 22, 2024 14:03
xinlifoobar
force-pushed
the
dev/xinli/parse_sql
branch
from
June 22, 2024 14:09
b220130 to
6035703
Compare
github-actions
Bot
removed
physical-expr
Contributor
Author
|
Sorry for the confusions... I merged a bad local main and messed up the histories. Fixed up. |
xinlifoobar
marked this pull request as ready for review
June 22, 2024 14:11
alamb
approved these changes
Jun 23, 2024
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
This looks great -- thanks again @xinlifoobar
9 tasks
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
* Draft parse_sql * Allow stirng pass * Complete sql to expr support * Add examples * Add unit tests * Fix format * Remove async for trival operation and add parquet demo * Fix comments * fix comments * fix comments * Fix doc link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #8736
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?