perf: Cache remapped expression in DynamicFilterPhysicalExpr::current()#20353
Closed
adriangb wants to merge 2 commits into
Closed
perf: Cache remapped expression in DynamicFilterPhysicalExpr::current()#20353adriangb wants to merge 2 commits into
adriangb wants to merge 2 commits into
Conversation
Contributor
Author
|
run benchmark tpcds |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
Author
|
run benchmark tpcds |
|
🤖 |
|
🤖: Benchmark completed Details
|
Contributor
Author
|
run benchmark tpcds |
|
🤖 |
|
🤖: Benchmark completed Details
|
`current()` calls `remap_children()` which does a full `transform_up()` tree walk on every invocation. This is called per-batch in `evaluate()`, `snapshot()`, etc. When the inner expression hasn't changed (the common case — updates are infrequent relative to evaluations), this tree walk is pure redundant work. Cache the remapped result per-instance using `Arc::ptr_eq` on the source expression for invalidation. When `update()` replaces `inner.expr` with a new `Arc`, the pointer naturally changes and the cache invalidates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use a named CachedCurrent struct instead of a tuple to satisfy clippy::type_complexity, and collapse nested if into a single let-chain to satisfy clippy::collapsible_if. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
adriangb
force-pushed
the
cache-current-dynamic
branch
from
February 22, 2026 17:25
d50740f to
5150ff9
Compare
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remap_children()inDynamicFilterPhysicalExpr::current()to avoid redundanttransform_up()tree walks on every per-batch call (evaluate(),snapshot(), etc.)Arc::ptr_eqon the source expression for cache invalidation — whenupdate()replaces the inner expression, the pointer naturally changesremapped_childrenisNone(no overhead on the producer path)Test plan
cargo test -p datafusion-physical-expr --lib expressions::dynamic_filters(9/9 pass)test_remap_childrenexercises update + evaluate on two consumers with different remapped children, verifying correctness after cache invalidation🤖 Generated with Claude Code