External Table Primary key support#7755
Merged
Merged
Conversation
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
github-actions
Bot
added
sql
ozankabak
approved these changes
Oct 6, 2023
ozankabak
left a comment
ozankabak
left a comment
Contributor
There was a problem hiding this comment.
I reviewed this PR and it looks good to me. It'd be good to get some community feedback in case something escaped my eye.
alamb
approved these changes
Oct 7, 2023
Contributor
There was a problem hiding this comment.
This looks really nice to me -- thank you @mustafasrepo
I think we should
- add a round trip test for the new protobuf code,
- Error if unsupported constraints are used
but otherwise, it looks good to go to me.
alamb
reviewed
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7154.
Thanks @parkma99 for the initial work in #7161
Rationale for this change
With the changes in this PR, we can use use primary key information in the external tables also.
What changes are included in this PR?
Are these changes tested?
Yes new tests are added to show that, primary key information is used during planning. With these changes query below can run
even if column
bis not among the group by expressions, when it is known that columncis primary key. In this case we are sure that, for each uniquecvalue, there will be correspondingbvalue (bis functionally dependent on thec). Hence, above query can run successfully.Are there any user-facing changes?