[Minor]: Remove input_schema field from window executor#7810
Merged
mustafasrepo merged 2 commits intoOct 13, 2023
Conversation
alamb
approved these changes
Oct 12, 2023
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
This is a nice cleanup and makes a lot of sense to me -- thank you @mustafasrepo
comphead
reviewed
Oct 12, 2023
comphead
left a comment
comphead
left a comment
Contributor
There was a problem hiding this comment.
👍
those 2 schemas were always super confusing
viirya
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
As far as I am aware we do not need to keep
input_schemain the state forWindowAggExecandBoundedWindowAggExec. We can reach this schema withself.input.schemawhen needed.What changes are included in this PR?
This PR removes
input_schemafromWindowAggExecandBoundedWindowAggExec.Are these changes tested?
Existing tests should work
Are there any user-facing changes?