Replace macro with function for array_remove#8106
Merged
Merged
Conversation
github-actions
Bot
added
physical-expr
jayzhan211
force-pushed
the
array-remove-rm-macro
branch
from
456c535 to
f0efbf8
Compare
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
force-pushed
the
array-remove-rm-macro
branch
from
f0efbf8 to
7b2b82f
Compare
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
alamb
approved these changes
Nov 13, 2023
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the contribution @jayzhan211 -- this is (yet another) great PR towards cleaning up the code for list handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Ref #7988
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
I did not consider all the null cases here, since there are still issues unsolved. We can add more null test cases after null handing gets better.