Improve documentation for calculate_prune_length method in SymmetricHashJoin#8125
Merged
Conversation
# Conflicts: # datafusion/physical-plan/src/joins/hash_join_utils.rs
alamb
approved these changes
Nov 10, 2023
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
This makes sense to me -- thank you @Asura7969
cc @metesynnada in case you have additional commentary to add
alamb
changed the title
SymmetricHashJoin
metesynnada
approved these changes
Nov 11, 2023
metesynnada
left a comment
metesynnada
left a comment
Contributor
There was a problem hiding this comment.
Removes the outdated comments, thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Improve documentation for calculate_prune_length method
What changes are included in this PR?
N/A
Are these changes tested?
doctests
Are there any user-facing changes?
Just Docs