ci: speed up win64 test#8728
Merged
Merged
Conversation
Jefffrey
changed the title
Contributor
Author
|
Limit to running only tpcds_physical_q44 with backtrace feature: good (2023-10-29 nightly) = 70 seconds bad (2023-10-30 nightly) = 692 seconds Without backtrace: good (2023-10-29 nightly) = 1.25 seconds bad (2023-10-30 nightly) = 1.26 seconds Trying more recent toolchains, with backtrace: 2023-12-21 nightly = 682 seconds 2024-01-01 nightly = 682 seconds |
Jefffrey
commented
Jan 6, 2024
| # use higher optimization level to overcome Windows rust slowness for tpc-ds | ||
| # and speed builds: https://github.com/apache/arrow-datafusion/issues/8696 | ||
| # Cargo profile docs https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings | ||
| RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C target-feature=+crt-static -C incremental=false -C codegen-units=256" |
Contributor
Author
There was a problem hiding this comment.
Removing the other optimization flags as it caused compilation to take 27 min
Without them, it takes 8 min
Contributor
Author
alamb
approved these changes
Jan 6, 2024
| # Cargo profile docs https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings | ||
| RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C target-feature=+crt-static -C incremental=false -C codegen-units=256" | ||
| # Minimize producing debug symbols to keep memory usage down | ||
| # Set debuginfo=line-tables-only as debuginfo=0 causes immensely slow build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #8696
Rationale for this change
Apply changes per analysis from rust-lang/rust#119560
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?