Skip to content

[feat](query) Add session_id to audit log - #51724

Closed
dolfinus wants to merge 1 commit into
apache:masterfrom
dolfinus:feature/audit-log-session-id
Closed

dolfinus wants to merge 1 commit into
apache:masterfrom
dolfinus:feature/audit-log-session-id

Conversation

@dolfinus

@dolfinus dolfinus commented Jun 14, 2025 •

Copy link
Copy Markdown

What problem does this PR solve?

Partially solves #49915

Problem Summary:

  • Add sessionId field to AuditEvent class
  • Update structure of internal audit_log table to include this column
  • Update AuditLogHelper to populate this field using ConnectionContext info
  • Add session_id column to AuditLoaderPlugin table
  • Use session_id column as part of primary key instead of client_ip (could be reverted)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes. Added new column to audit_log table & AuditLoaderPlugin
  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dolfinus
dolfinus force-pushed the feature/audit-log-session-id branch 2 times, most recently from 2740b4d to f331542 Compare June 14, 2025 14:25
@dolfinus
dolfinus marked this pull request as ready for review June 14, 2025 14:33
@github-actions

Copy link
Copy Markdown
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions Bot added the Stale label Dec 12, 2025
Signed-off-by: Martynov Maxim <martinov_m_s_@mail.ru>
@dolfinus
dolfinus force-pushed the feature/audit-log-session-id branch from f331542 to e83ace3 Compare December 12, 2025 08:16
@dolfinus

Copy link
Copy Markdown
Author

Could anyone take a look?

@github-actions github-actions Bot removed the Stale label Dec 13, 2025
@github-actions

Copy link
Copy Markdown
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions Bot added the Stale label Jun 11, 2026
@github-actions github-actions Bot closed this Jun 21, 2026
@morningman morningman reopened this Jun 23, 2026
@github-actions github-actions Bot closed this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants