Skip to content

Refactor dubbo spring boot structure - #14794

Merged
CrazyHZM merged 6 commits into
apache:3.3from
CrazyHZM:feat/refactor-spring-boot
Oct 31, 2024
Merged

Refactor dubbo spring boot structure#14794
CrazyHZM merged 6 commits into
apache:3.3from
CrazyHZM:feat/refactor-spring-boot

Conversation

@CrazyHZM

Copy link
Copy Markdown
Member

What is the purpose of the change?

Checklist

  • Make sure there is a GitHub_issue field for the change.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

Signed-off-by: “JermaineHua” <crazyhzm@gmail.com>
@CrazyHZM
CrazyHZM force-pushed the feat/refactor-spring-boot branch 3 times, most recently from 7bac4b3 to ad27356 Compare October 20, 2024 05:36
@CrazyHZM
CrazyHZM force-pushed the feat/refactor-spring-boot branch from ad27356 to 1f66713 Compare October 20, 2024 14:50
# Conflicts:
#	dubbo-spring-boot/pom.xml
@CrazyHZM
CrazyHZM force-pushed the feat/refactor-spring-boot branch from 32d9bb6 to 6e4543a Compare October 26, 2024 15:18
@oxsean

oxsean commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

Some suggestions for reference only:

  • Rename dubbo-spring-boot-project to dubbo-spring-boot-all
  • Move dubbo-spring-boot-compatible/dubbo-spring-boot-autoconfigure-compatible to dubbo-spring-boot-1-autoconfigure
  • Move dubbo-spring-boot-compatible/dubbo-spring-boot-actuator-autoconfigure-compatible to dubbo-spring-boot-1-actuator-autoconfigure

Comment thread pom.xml Outdated
Comment thread dubbo-spring-boot/pom.xml
Comment thread dubbo-spring-boot-project/dubbo-spring-boot-autoconfigure/pom.xml
Comment thread dubbo-spring-boot-project/dubbo-spring-boot-3-autoconfigure/pom.xml
@CrazyHZM

Copy link
Copy Markdown
Member Author

Some suggestions for reference only:

  • Rename dubbo-spring-boot-project to dubbo-spring-boot-all
  • Move dubbo-spring-boot-compatible/dubbo-spring-boot-autoconfigure-compatible to dubbo-spring-boot-1-autoconfigure
  • Move dubbo-spring-boot-compatible/dubbo-spring-boot-actuator-autoconfigure-compatible to dubbo-spring-boot-1-actuator-autoconfigure

dubbo-spring-boot-all strikes me as fatjar, but for now, it's just a directory of files, so I think dubbo-spring-boot-project is more appropriate

dubbo-spring-boot-compatible also needs to exist because it is managed as a 1.x bom, otherwise, it cannot override the parent's high version dependencies.

Signed-off-by: “JermaineHua” <crazyhzm@gmail.com>
# Conflicts:
#	dubbo-spring-boot/pom.xml
@CrazyHZM
CrazyHZM force-pushed the feat/refactor-spring-boot branch from 3623401 to 5d8d078 Compare October 30, 2024 14:36
Signed-off-by: “JermaineHua” <crazyhzm@gmail.com>
@CrazyHZM
CrazyHZM force-pushed the feat/refactor-spring-boot branch from 5d8d078 to 21d9b5b Compare October 30, 2024 15:08
@CrazyHZM
CrazyHZM merged commit e5383b9 into apache:3.3 Oct 31, 2024
@CrazyHZM
CrazyHZM deleted the feat/refactor-spring-boot branch October 31, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants