fix(geo): respect tooltip.show=false in geo region tooltip config (Fixes #20232) - #21719
Open
waterWang wants to merge 1 commit into
Open
fix(geo): respect tooltip.show=false in geo region tooltip config (Fixes #20232)#21719waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
geo.tooltip.showis set tofalse, the tooltip still shows when hovering over geo regions becauseresetTooltipForRegionunconditionally sets the tooltip config on each region element.Root Cause
In
src/component/helper/MapDraw.ts, theresetTooltipForRegionfunction always callsgraphic.setTooltipConfig()with the region's tooltip option, without checking whethershow: falseis explicitly set.Fix
Added a guard in
resetTooltipForRegionto check if the tooltip option hasshow: falsebefore setting the tooltip config. If the tooltip is explicitly disabled, the function returns early without setting the config, so the tooltip component will not show a tooltip for that region.Related Issue
Fixes #20232