[Bug] Unable to set use1904windowing when reading xlsx files

[delei]

Search before asking

• I searched in the issues and found nothing similar.

Fastexcel version

1.2.0

JDK version

OpenJDK 1.80_452

Operating system

No response

Minimal reproduce step

Test case

@Slf4j
public class Issue3745Test {
    @Test
    void testUse1904windowing() throws Exception {
        File testFile = TestFileUtil.createNewFile("issue/easyexcel/test.xlsx");

        // write file
        FastExcel.write(testFile, DemoData.class).excelType(ExcelTypeEnum.XLSX)
                .use1904windowing(Boolean.TRUE)  // set use1904windowing to TRUE
                .sheet()
                .doWrite(demoData(1));

        FastExcel.read(testFile, new AnalysisEventListener<DemoData>() {
                    @Override
                    public void invoke(DemoData data, AnalysisContext context) {
                        boolean isUse1904windowing = context.readSheetHolder().globalConfiguration().getUse1904windowing();
                        log.info("isUse1904windowing: {}", isUse1904windowing);
                        Assertions.assertTrue(isUse1904windowing);
                    }

                    @Override
                    public void doAfterAllAnalysed(AnalysisContext context) {
                    }
                })
                .excelType(ExcelTypeEnum.XLSX)
                .head(DemoData.class)
                .sheet()
                .doReadSync();
    }

    private List<DemoData> demoData(int size) {
        List<DemoData> dataList = new ArrayList<>();
        for (int i = 0; i < size; i++) {
            DemoData demoData = new DemoData();
            demoData.setString("String" + i);
            demoData.setDate(DateUtil.date());
            demoData.setDoubleData(RandomUtil.randomDouble());
            dataList.add(demoData);
        }
        return dataList;
    }
}

What did you expect to see?

For the xlsx files, according to the logic of XlsxSaxAnalyser#analysisUse1904WindowDate method , the value of use1904windowing should be true when reading the file.

What did you see instead?

The value of use1904windowing always be false.

Anything else?

Related Issue

easyexcel-issue-3745

Are you willing to submit a PR?

• I'm willing to submit a PR!

[delei]

I am a little confused. the xlsxReadWorkbookHolder.globalConfiguration().getUse1904windowing() always be false ?Under what circumstances would it be null?

https://github.com/fast-excel/fastexcel/blob/c82e99998d9811b0c727a4d4ce3e46370f6efd9f/fastexcel/src/main/java/cn/idev/excel/analysis/v07/XlsxSaxAnalyser.java#L175-L189

[mymde]

FastExcel.read(testFile, new AnalysisEventListener<DemoData>() {
                @Override
                public void invoke(DemoData data, AnalysisContext context) {
                    boolean isUse1904windowing = context.readSheetHolder().globalConfiguration().getUse1904windowing();
                    log.info("isUse1904windowing: {}", isUse1904windowing);
                    Assertions.assertTrue(isUse1904windowing);
                }

                @Override
                public void doAfterAllAnalysed(AnalysisContext context) {
                }
            })
            .excelType(ExcelTypeEnum.XLSX)
            .head(DemoData.class)
            .use1904windowing(Boolean.TRUE)
            .sheet()
            .doReadSync();

How to use it like this？

[delei]

How to use it like this？

According to the logic of XlsxSaxAnalyser#analysisUse1904WindowDate() method, I think it can be parsed from the file instead of manually setting use1904windowing to true when reading.

[mymde]

 public GlobalConfiguration() {
        this.autoTrim = Boolean.TRUE;
        this.use1904windowing = Boolean.FALSE;
        this.locale = Locale.getDefault();
        this.useScientificFormat = Boolean.FALSE;
        this.filedCacheLocation = CacheLocationEnum.THREAD_LOCAL;
    }

This code initializes the use1904windowing.

[delei]

This code initializes the use1904windowing.

Yes.I also noticed that there is a check for null values here, but I have questions about the use of the scenario, and how to set to null ?

https://github.com/fast-excel/fastexcel/blob/c82e99998d9811b0c727a4d4ce3e46370f6efd9f/fastexcel/src/main/java/cn/idev/excel/metadata/AbstractHolder.java#L58-L75

[delei]

Hi, @mymde
😄 Are you willing to look into this issue and submit a PR ?

[mymde]

I checked the commit history of EasyExcel and found that on September 13, 2021, if you remove the line this.use1904windowing = Boolean.FALSE from the GlobalConfiguration and then run CellDataDataTest#t03ReadAndWriteCsv(), an error will occur. It was to fix this issue that the author added the code this.use1904windowing = Boolean.FALSE.

[delei]

I checked the commit history of EasyExcel and found that on September 13, 2021, if you remove the line this.use1904windowing = Boolean.FALSE from the GlobalConfiguration and then run CellDataDataTest#t03ReadAndWriteCsv(), an error will occur. It was to fix this issue that the author added the code this.use1904windowing = Boolean.FALSE.

Thank you for the useful information you have provided.