Skip to content

fix: render negative date serials as numbers - #1117

Open
nkuprins wants to merge 4 commits into
apache:mainfrom
nkuprins:fix/negative-serial-date-format
Open

nkuprins wants to merge 4 commits into
apache:mainfrom
nkuprins:fix/negative-serial-date-format

Conversation

@nkuprins

@nkuprins nkuprins commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Closed: #1116

Purpose of the pull request

As title.

What's changed?

  • Negative Excel date serials now fall back to general number formatting instead of throwing.
  • Adds a parameterised test pinning the fix.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

…ormat

# Conflicts:
#	fesod-sheet/src/test/java/org/apache/fesod/sheet/metadata/format/DataFormatterTest.java
@nkuprins
nkuprins marked this pull request as ready for review October 10, 2026 09:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Negative value in a date format aborts the read with ExcelDataConvertException

1 participant