Repository navigation
Update selenium & spock - #338
Merged
Merged
Conversation
Selenium 4.45 (PR #17530) switched the Java bindings' isDisplayed atom from the old Closure bot.dom.isShown to a new TypeScript is-displayed.ts. The Java bindings have always run this atom via executeScript for W3C sessions, so only the atom's rules changed. Both atoms say a zero-size element is displayed only if a child has positive size or is a text node. The rule for text nodes changed: - Old atom: any text node counts, including whitespace. - New atom: a whitespace-only text node that contains a newline or tab does not count. This required us to add some content to our sample paragraphs for them to behave as expected for this test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should address the concern behind #322, as well as get us up to date for a final Groovy 4 release before moving on to Groovy 5 (and then, soon enough, 6).