Conversation
|
💔 -1 overall
This message was automatically generated. |
vt921102
force-pushed
the
trunk
branch
2 times, most recently
from
June 10, 2026 00:16
cb4f028 to
0864c91
Compare
|
💔 -1 overall
This message was automatically generated. |
vt921102
force-pushed
the
trunk
branch
4 times, most recently
from
August 18, 2026 03:20
302e17e to
5201a91
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
vt921102
force-pushed
the
trunk
branch
2 times, most recently
from
August 20, 2026 03:09
d89f1ef to
1a02e8b
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Author
|
@Hexiaoqiao @shfshihuafeng would you have time to take a look at this one? It is a one-line ABFS fix for HDFS-17881. All checks are green: Backports are prepared for the release branches: #8692 (branch-3.5) and Thanks! |
Author
|
@cnauroth @steveloughran would you be able to review this as well? The change is HDFS-17881: All checks are green: One process question: the JIRA is filed under the HDFS project with component Thanks! |
Contributor
|
* as noted, I'm not working. taking august off and doing something completely different from mid sept. sorry
only worry about this pr, asking for other branches is a distraction. the backports are just that, backports of whatever is in trunk, and shouldn't be different except where some incompatiblity (like junit) force it. get this one, submit those PRs with a declaration of which azure endpoints you reran the hadoop azure itests against (i.e. |
vt921102
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…hildren folder with colon in Windows.
ABFS built list-status entry paths with File.separator, which is a
backslash on Windows. Path("\name:x") then treats "\name" as a URI
scheme, so listing a directory whose children contain a colon failed
with URISyntaxException. The separator here is part of an ABFS/URI
path, not a local filesystem path, so use a forward slash
unconditionally.
Contains content generated by Claude.
Generated-by: Claude Opus 5
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
🎊 +1 overall
This message was automatically generated. |
anujmodi2021
approved these changes
Sep 9, 2026
anujmodi2021
left a comment
anujmodi2021
left a comment
Contributor
There was a problem hiding this comment.
+1
LGTM
Would be good to test this against a real storage account. May be run some integration test if not already done.
anmolanmol1234
approved these changes
Sep 9, 2026
Contributor
|
I am not set up to test against msft storage. Anyone who hits problems with azure storage must have an account, and so should be able to get set up for this. please get set up for testing...we can't be getting changes into a cloud storage connector that isn't being tested against that store, as it will ship and regressions not found out until it is actually in production. |
Author
|
Hi @anujmodi2021 , NoteRan the full hadoop-azure integration suite on commit 6beae98 (this PR rebased on trunk) Results (failsafe): 1362 tests, 1136 passed, 0 failures, 12 errors, 214 skipped. All errors/failures are pre-existing and unrelated to this change:
ITestAzureBlobFileSystemListStatus (21 tests), ITestAbfsListStatusRemoteIterator |
Contributor
|
Thanks @vt921102 @steveloughran do you see any other concerns with this change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Fixes HADOOP-19973.
AbfsClient.getVersionedFileStatusFromEntry()built the entry path asnew Path(File.separator + entry.name()). On WindowsFile.separatoris abackslash, so for a child entry named
FestSpecial:the string handed toPathis\FestSpecial:.Pathlooks for the first:before the first/; finding no/, it treats\FestSpecialas a URI scheme and listingfails:
The separator here is part of an ABFS/URI path, not a local filesystem path,
so it must always be
/. Linux was unaffected becauseFile.separatorisalready
/there.Backports: #8692 (branch-3.5), #8693 (branch-3.4).
How was this patch tested?
New unit test
TestAbfsClient#testGetVersionedFileStatusFromEntryUsesForwardSlash,asserting the entry path is built with
/independently of the platform'sFile.separator. It fails on Windows before the fix and is a regression guardon every platform afterwards. Yetus reported
+1 unit — hadoop-azure in the patch passedon the pre-rebase revision; CI is re-running after the rebaseonto current trunk.
Manually reproduced and verified against Azure Data Lake Storage using the
test_hadoop_azure.zipreproducer attached to the JIRA (AbfsListStatusOAuthTest.java).Integration test endpoint declaration: TODO — see
hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles? (not applicable)AI Tooling
If an AI tool was used:
Contains content generated by Claude in creating the unit test.
Note
Ran the full hadoop-azure integration suite on commit 6beae98 (this PR rebased on trunk)
against ataccamahadoopabfsitest.dfs.core.windows.net (Azure region: North Europe),
HNS-enabled, auth = SharedKey, on macOS / JDK 17:
Results (failsafe): 1362 tests, 1136 passed, 0 failures, 12 errors, 214 skipped.
Results (surefire): 238 tests, 233 passed, 1 failure, 4 skipped.
Duration: 54:59
All errors/failures are pre-existing and unrelated to this change:
ITestAbfsClient.testAuthTypeProviderSetup[OAuth, SAS, UserboundSASWithOAuth]:
"Failed to initialize null" in AbfsConfiguration.getTokenProvider — the test
account has no OAuth/SAS token provider configured (SharedKey-only run).
trunk without this patch on macOS; timing-dependent eviction test.
ITestAzureBlobFileSystemListStatus (21 tests), ITestAbfsListStatusRemoteIterator
and the contract tests pass. The run was executed by my colleague Pavel Chuchma
on our team's storage account; I have the full logs and failsafe reports.