Update annotation with V3#1587
Merged
Merged
Conversation
kevinjqliu
reviewed
Jan 28, 2025
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
i swear i saw this was already done. turns our there are 2 dups!!
iceberg-python/pyiceberg/table/metadata.py
Line 568 in 1adbb87
Contributor
Author
|
@kevinjqliu Maybe you already saw this at the Deletion Vector PR: https://github.com/apache/iceberg-python/pull/1516/files#diff-a7fbd8c6b0564308ca872ba479f0e240ff2c893d15776a14e52b91b48e9ac470R693 I noticed it over there that it was missing, but it isn't really part of the DV PR. |
Contributor
Author
|
Ah good catch @kevinjqliu. Probably the |
Contributor
|
Already added in #1554 |
Contributor
Author
|
Less is more, thanks @kevinjqliu 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed this in #1554