GCP: Add CEL-Java to the gcp-bundle LICENSE - #18226
Merged
RussellSpitzer merged 2 commits intoSep 23, 2026
Merged
RussellSpitzer merged 2 commits into
RussellSpitzer merged 2 commits into
Conversation
iceberg-gcp-bundle ships dev.cel:common, dev.cel:protobuf, and dev.cel:runtime through google-cloud-storage and google-cloud-kms, but LICENSE does not name CEL-Java. dev.cel:protobuf also ships the CEL specification protos unshaded, so the existing CEL specification entry now notes both sources. Generated-by: GitHub Copilot (Claude Opus 5.5) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…undle LICENSE httpclient 4.5 also ships mozilla/public-suffix-list.txt in the bundle, not only Google Guava. Generated-by: GitHub Copilot (Claude Opus 5.5) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
nssalian
approved these changes
Sep 23, 2026
RussellSpitzer
approved these changes
Sep 23, 2026
Member
|
Merged, Thanks @huaxingao and @nssalian for the review and @kevinjqliu for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things bundled in gcp-bundle aren't fully credited in its LICENSE. Found both while auditing the 1.12 runtime deps.
dev.cel:*) through google-cloud-storage and google-cloud-kms. It's Apache-2.0 with no NOTICE, so nothing is legally missing, but we list every bundled dependency. It also ships the CEL spec protos we already credit to gRPC-xds.mozilla/public-suffix-list.txt).This adds a CEL-Java entry, lists it as a second source of the CEL spec, and credits Apache HttpComponents in the Public Suffix List entry.
Test plan: LICENSE only. Checked against the bundled jars.
AI Disclosure