Skip to content
This repository was archived by the owner on Mar 9, 2023. It is now read-only.

Move Travis CI out from sub-directory - #1

Merged
lucasbm88 merged 2 commits into
apache:masterfrom
Wei-1:master
Nov 7, 2018
Merged

lucasbm88 merged 2 commits into
apache:masterfrom
Wei-1:master

Conversation

@Wei-1

@Wei-1 Wei-1 commented Oct 17, 2018

Copy link
Copy Markdown
Member

To help Travis CI to run the test.
I moved .travis.yml out from the sub-directories.
The travis tests are already testing with:

Build Status

One can modify the apache travis ci setting to get a proper link.
And put it in readme.

P.S. Public Engines is currently not buildable due to dependency issue.
Will need to be separated into another issue.
This PR only covers Engine Executor and Python Toolbox

Comment thread .travis.yml Outdated
script:
- marvin test
- codecov
# Public Engines

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason for letting this commented?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Point.
Public Engines are currently unbuildable caused by dependency issues.
But instead of leaving it commented, I will delete these for simplicity.

@Wei-1

Wei-1 commented Oct 25, 2018

Copy link
Copy Markdown
Member Author

Thx @lucasbm88 for the review, I removed the unbuildable part.

@lucasbm88

Copy link
Copy Markdown
Contributor

Hey @Wei-1, just a quick update. I've approved your PR. However, we have some issues with our Apache repo rn and I can't merge, I am trying to figure out asap and I let you know.

@Wei-1

Wei-1 commented Nov 6, 2018

Copy link
Copy Markdown
Member Author

Sure. I will like to help if there is anything that I can help.

@lucasbm88

Copy link
Copy Markdown
Contributor

Sure. I will like to help if there is anything that I can help.

Awesome, please subscribe to our dev mail list and be part of the discussions with us.
dev@marvin.incubator.apache.org

@lucasbm88
lucasbm88 merged commit a0e318a into apache:master Nov 7, 2018
@Wei-1
Wei-1 deleted the master branch December 20, 2018 03:17
rafaelnovello pushed a commit that referenced this pull request Jan 22, 2019
Develop branch sync with upstream
oldfly pushed a commit that referenced this pull request Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants