feat(bitbucket): add guarded cloud PR approve actions - #1186
Merged
Conversation
Contributor
Author
|
Hi @potiuk — this is the next narrow #606 follow-up after the Cloud PR-comment write. It adds guarded Bitbucket Cloud The full Bitbucket test suite, Ruff, mypy, prek hooks, and Would appreciate your review when you get a chance. |
potiuk
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds guarded Bitbucket Cloud pull-request approval mutations to the existing Bitbucket bridge.
This PR adds:
magpie-bitbucket pr approve <id>magpie-bitbucket pr unapprove <id>The commands operate on Bitbucket Cloud only. Bitbucket Data Center approval writes remain explicitly unsupported in this PR.
Implementation
Adds a shared guarded write request helper supporting:
POSTresponses with JSON bodiesDELETEresponses such as Bitbucket Cloud's204 No ContentAdds Bitbucket Cloud approve and unapprove API calls.
Adds explicit Data Center fail-closed behavior.
Adds normalized approval mutation output.
Adds CLI dispatch for
pr approveandpr unapprove.Keeps the broader
post_reviewcontract marked as not implemented.Safety / write-path discipline
These remain explicit caller-confirmed mutations.
The bridge does not perform approval writes automatically. The calling skill is responsible for obtaining explicit user confirmation before invoking the mutation.
Authenticated writes continue to reject redirects rather than forwarding credentials to a redirected destination.
Tests
Added coverage for:
POSTwith no request bodyDELETEwith an empty response bodyValidation completed successfully:
git diff --checkScope
This intentionally remains a narrow follow-up to #606.
It does not add:
post_review