fix(runtime-host): log transcript bootstrap failures - #5600
Conversation
Refs apache#5572 Generated-by: Codex
hqhq1025
left a comment
There was a problem hiding this comment.
I reviewed current head e1a6161e5decd6fb9678e78c285e3482ac409adb and found no substantiated P0–P3 issue in the changed paths.
The subscription.open tail-transcript bootstrap catch now logs a bounded, redacted diagnostic before invoking the publication-failure hook, while the client still receives a generic persistence_failed response (packages/runtime-host/src/server/session-continuity-coordinator.ts:942-980). I checked failure ordering, log/client separation, the existing redaction and UTF-8 bound, and the added regression test. There is no database schema migration. Current-head test and label checks pass and the branch merges cleanly with current main.
I could not rerun tests locally (Node 18 and no dependencies), exhaustively audit arbitrary custom exception contents, or test multi-subscriber/restart log aggregation. This is not a merge approval.
Automated review notice: This comment was posted by an automated review agent operated by hqhq1025. It is not an independent human review and does not replace one.
Astro-Han
left a comment
There was a problem hiding this comment.
Approved at @Astro-Han's explicit request: a small, focused fix with no blocking findings in the automated review of this head and green CI.
A transcript page that failed answered `persistence_failed` and a failed subscription bootstrap answered with a generic outcome; neither left the cause anywhere. Both now log it first, bounded and redacted (a capacity refusal is expected and stays quiet). An incomplete RuntimeEvent projection names its invocation and each hard diagnostic's code and ids instead of one fixed sentence, and never the event content. Lead: apache#5573 (22c2a81), apache#5600 (f897600), apache#5601 (23b4d8a). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Watermark bfb315a. Done: apache#5573/apache#5600/apache#5601, apache#5521, apache#4875, apache#5723, apache#5738, apache#5742. Not applicable: apache#5737, apache#5593. Deferred: apache#5730. Consider: apache#5599, apache#5120, apache#5693. Diverged: apache#5740. Skipped: ACP, WorkHub, upstream renderer and packages/ui, one refactor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
When the initial
subscription.opentranscript bootstrap fails, the Host now logs the underlying cause before invoking the publication-failure hook. The diagnostic uses existing secret redaction and an 8 KiB limit; the hook still receives the original error, and the client still receivespersistence_failed.Refs #5572
Verification
npm run build,npm run typecheck,npm run lint, andnpm run format:checkpassed.npm testwas not run.AI use
Tool(s) and scope: Codex implemented the diagnostic logging and regression test, ran validation, and prepared this PR.
Checklist
Does this PR entail a change in behavior?