Skip to content

Trailing comma in unpackTypes causes empty string element and confusing error #522

Description

@elharo

Description

In EarMojo.java:460, a trailing comma in the unpackTypes parameter produces an empty string element:

unpackTypesList = Arrays.asList(unpackTypes.split(","));

If the user configures unpackTypes = "jar,war,", split(",") produces the array ["jar", "war", ""]. The empty string "" will fail isStandardArtifactType() and produce a confusing error message.

Expected behavior

Filter out empty strings:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingpriority:minorMinor loss of function, or other problem where easy workaround is present

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions