You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
help:evaluate can receive model collections implemented by Maven's internal ModelMerger.MergingList. XStream does not recognize that implementation as a collection and falls back to reflective serialization, which fails when it tries to access AbstractList.modCount on recent JDKs.
This change registers a collection converter that accepts every Collection implementation and aliases the concrete runtime list class so the existing XML root name is preserved. The evaluated list is serialized directly without copying it.
The commits are intentionally split: the first adds the regression IT and fails with the reflection error; the second applies the fix.
Validation
Maven 3.10.0-rc-1 / JDK 17 clean verify: all 22 unit tests passed
Maven 3.9.16 / JDK 21 -Prun-its clean verify: all 22 unit tests and all 35 ITs passed
Maven 3.10.0-rc-1 / JDK 17 -Prun-its clean verify: the regression IT passed; 34 of 35 ITs passed, with the unrelated existing describe-cmd assertion failing because the deploy lifecycle mapping was reported as undefined
Checklist
This pull request addresses one issue without unrelated changes.
The description explains what changed, how, and why.
Each commit has a meaningful subject line and body. Commit subjects are meaningful; no commit bodies were added.
A regression integration test fails without the runtime change.
mvn verify was run successfully.
The complete integration-test suite was run successfully with Maven 3.9.16; the Maven 3.10.0-rc-1 boundary is documented above.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004.
In any other case, an Apache Individual Contributor License Agreement has been filed.
Heads-up before this goes further: maven-help-plugin-3.4.x is on the list of Doxia 1.x maintenance
branches being reviewed for retirement now that the Doxia 2.0.0 stack is complete. It is also the
last line here declaring mavenVersion 3.6.3 — master is at 3.9.16 — so as written these fixes have
nowhere else to land.
So the question is yours to answer first: do you want the 3.4.x line kept alive, and is a 3.4.2
release realistic? If yes, it stays and this is a non-issue. If not, the alternative is raising the
Maven 3.10 lifecycle-mapping and ModelMerger.MergingList fixes against master for users on 3.9.16+.
Closing this 3.4.x-targeted PR before republishing the same head branch as a new PR against master, the current 3.5.x line. The Maven 3 issue remains reproducible in Help Plugin 3.5.2; the replacement PR carries the regression and fix forward with updated validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #327 for the Maven 3 maintenance line.
help:evaluatecan receive model collections implemented by Maven's internalModelMerger.MergingList. XStream does not recognize that implementation as a collection and falls back to reflective serialization, which fails when it tries to accessAbstractList.modCounton recent JDKs.This change registers a collection converter that accepts every
Collectionimplementation and aliases the concrete runtime list class so the existing XML root name is preserved. The evaluated list is serialized directly without copying it.The commits are intentionally split: the first adds the regression IT and fails with the reflection error; the second applies the fix.
Validation
clean verify: all 22 unit tests passed-Prun-its clean verify: all 22 unit tests and all 35 ITs passed-Prun-its clean verify: the regression IT passed; 34 of 35 ITs passed, with the unrelated existingdescribe-cmdassertion failing because thedeploylifecycle mapping was reported as undefinedChecklist
This pull request addresses one issue without unrelated changes.
The description explains what changed, how, and why.
Each commit has a meaningful subject line and body. Commit subjects are meaningful; no commit bodies were added.
A regression integration test fails without the runtime change.
mvn verifywas run successfully.The complete integration-test suite was run successfully with Maven 3.9.16; the Maven 3.10.0-rc-1 boundary is documented above.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004.
In any other case, an Apache Individual Contributor License Agreement has been filed.