Add invoker.failedGoal to assert which goal an IT build failed on - #763
Draft
slachiewicz wants to merge 1 commit into
Draft
slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
invoker.buildResult = failure accepts any failure, so a test stays green when the IT build breaks for an unrelated reason. The exit code cannot tell which goal failed, so the goal is read back from build.log. Fixes #503
Member
|
As we execute new Maven instance for each test we can provide a extension with ExecutionListener which collect status of executed goals instead of parsing logs. We can save report in file and should be easy to read it |
slachiewicz
marked this pull request as draft
September 17, 2026 19:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
invoker.failedGoal, which pins a failing IT to one goal so thatinvoker.buildResult = failurecan no longer be satisfied by an unrelated failure. The value is a colon separated list of fragments matched in order against thegroupId:artifactId:version:goalcoordinates Maven logs, with an optional execution id in parentheses, somaven-enforcer-plugin:enforceand the full coordinates both work. The check reads theFailed to execute goal ...line out of thebuild.logthe plugin already owns rather than hooking into the forked build, and it is rejected wheninvoker.buildResultis notfailureor whennoLogdisabled the log.Fixes #503
This change was created with AI assistance.