Fail clearly when configureLocator has no project POM #275

src/main/java/org/apache/maven/plugin/resources/remote/AbstractProcessRemoteResourcesMojo.java

@@ -424,10 +424,9 @@
             }
         }
 
-        configureLocator();
-
         ClassLoader origLoader = Thread.currentThread().getContextClassLoader();
         try {
+            configureLocator();
             validate();
 
             List<File> resourceBundleArtifacts = downloadBundles(resourceBundles);
@@ -495,8 +494,12 @@
             }
         }
 
-        locator.addSearchPath(
-                FileResourceLoader.ID, project.getFile().getParentFile().getAbsolutePath());
+        File projectFile = project.getFile();
+        if (projectFile == null) {
+            throw new MojoExecutionException(
+                    "The current project has no POM file; cannot configure the resource locator.");
+        }
+        locator.addSearchPath(FileResourceLoader.ID, projectFile.getParentFile().getAbsolutePath());
         if (appendedResourcesDirectory != null) {
             locator.addSearchPath(FileResourceLoader.ID, appendedResourcesDirectory.getAbsolutePath());
         }
@@ -649,7 +652,7 @@
                     }
                 } else {
                     getLog().debug("Use project resource '" + source + "' as resource");
                     FilteringUtils.copyFile(source, outputFile, null, null);
                 }
 
                 // exclude the original (so eclipse doesn't complain about duplicate resources)
@@ -669,7 +672,7 @@
         File source = new File(project.getBasedir(), bundleResourceName);
         if (source.exists()) {
             getLog().debug("Use project file '" + source + "' as resource");
             FilteringUtils.copyFile(source, outputFile, null, null);
             return true;
         }
 

src/test/java/org/apache/maven/plugin/resources/remote/RemoteResourcesMojoTest.java

@@ -41,9 +41,10 @@
 import org.apache.maven.execution.DefaultMavenExecutionRequest;
 import org.apache.maven.execution.DefaultMavenExecutionResult;
 import org.apache.maven.execution.MavenSession;
+import org.apache.maven.plugin.MojoExecutionException;
 import org.apache.maven.plugin.resources.remote.stub.MavenProjectBuildStub;
 import org.apache.maven.plugin.resources.remote.stub.MavenProjectResourcesStub;
 import org.apache.maven.plugin.testing.AbstractMojoTestCase;
 import org.apache.maven.project.MavenProject;
 import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
 import org.codehaus.plexus.util.FileUtils;
@@ -58,7 +59,7 @@
 /**
  * RemoteResources plugin Test Case
  */
 public class RemoteResourcesMojoTest extends AbstractMojoTestCase {
     static final String DEFAULT_BUNDLE_POM_PATH = "target/test-classes/unit/rrmojotest/bundle-plugin-config.xml";
     static final String DEFAULT_PROCESS_POM_PATH = "target/test-classes/unit/rrmojotest/process-plugin-config.xml";
 
@@ -91,6 +92,21 @@
         mojo.execute();
     }
 
+    public void testConfigureLocatorRequiresProjectFile() throws Exception {
+        final MavenProjectResourcesStub project = createTestProject("default-null-pom");
+        final ProcessRemoteResourcesMojo mojo = lookupProcessMojoWithDefaultSettings(project);
+
+        setupDefaultProject(project);
+        project.setFile(null);
+
+        try {
+            mojo.execute();
+            fail("expected MojoExecutionException when the project has no POM file");
+        } catch (MojoExecutionException e) {
+            assertTrue(e.getMessage().contains("no POM file"));
+        }
+    }
+
     public void testCreateBundle() throws Exception {
         List<String> resources =
                 Arrays.asList("FILTER.txt.vm", "ISO-8859-1.bin.vm", "PROPERTIES.txt.vm", "SIMPLE.txt", "UTF-8.bin.vm");
@@ -246,7 +262,7 @@
         final ProcessRemoteResourcesMojo mojo =
                 lookupProcessMojoWithSettings(project, new String[] {"test-filtered-bundles:test-filtered-bundles:2"});
 
         mojo.includeProjectProperties = true;
         setupDefaultProject(project);
 
         project.addProperty("testingPropertyOne", "maven");