Drop the versions.junit5 property the parent already provides - #2054
Merged
Merged
Conversation
slachiewicz
added
maintenance
dependencies
slachiewicz
marked this pull request as ready for review
August 9, 2026 14:33
org.apache.maven:maven-parent:49 already sets versions.junit5 to 5.14.4 and is the only pom that reads it -- no pom in this repository references the property. The local copy just has to be kept in step by hand. It was the only entry under the "Parent versions" heading, so the comment and the blank line that separated the group go with it rather than being left labelling nothing. Generated-by: Claude Opus 5 (1M context)
slachiewicz
force-pushed
the
drop-redundant-parent-properties
branch
from
August 9, 2026 14:53
bf5d39a to
f2ef152
Compare
elharo
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.apache.maven:maven-parent:49already setsversions.junit5to 5.14.4 — the identical value — and it is the only pom that reads the property: nothing in this repository references${versions.junit5}. The local copy therefore changes nothing and simply has to be kept in step with the parent by hand.Part of a sweep across the Maven repositories for local pom properties that no longer override anything.
mvn help:effective-pomis unchanged by this removal.Generated-by: Claude Opus 5 (1M context)