Skip to content

Create the local repository directory before resolving its real path #2111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstamas merged 1 commit into from
Sep 2, 2026
Merged

Create the local repository directory before resolving its real path #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...r-impl/src/main/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ public synchronized void clear() {
this.trackingFilename = requireNonNull(trackingFilename);
this.trackingFileManager = requireNonNull(trackingFileManager);
this.localPathPrefixComposer = requireNonNull(localPathPrefixComposer);
// a fresh local repository does not exist yet; toRealPath() requires it to
Files.createDirectories(getRepository().getBasePath());
this.realBasePath = getRepository().getBasePath().toRealPath();
}

Expand Down
30 changes: 30 additions & 0 deletions ...test/java/org/eclipse/aether/internal/impl/EnhancedLocalRepositoryManagerFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@
*/
package org.eclipse.aether.internal.impl;

import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;

import org.eclipse.aether.ConfigurationProperties;
import org.eclipse.aether.DefaultRepositorySystemSession;
Expand All @@ -34,6 +37,7 @@
import org.eclipse.aether.repository.LocalRepository;
import org.eclipse.aether.repository.LocalRepositoryManager;
import org.eclipse.aether.repository.RemoteRepository;
import org.eclipse.aether.spi.localrepo.LocalRepositoryManagerFactory;
import org.eclipse.aether.util.StringDigestUtil;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -145,4 +149,30 @@ void trackingSpecificConfigurationOverridesSystemWideFunction() throws Exception
new LocalArtifactRequest(artifact, Collections.singletonList(impostor), context);
assertFalse(manager.find(session, fromImpostor).isAvailable());
}

@Test
void newInstanceForNotYetExistingBasedir() throws Exception {
// a fresh local repository (first build on a machine, or a new -Dmaven.repo.local) does not exist yet
Path missing = basedir.resolve("not-yet-created");
assertFalse(Files.exists(missing));

LocalRepositoryManager manager = factory.newInstance(session, new LocalRepository(missing));

assertInstanceOf(EnhancedLocalRepositoryManager.class, manager);
}

@Test
void providerSelectsEnhancedManagerForNotYetExistingBasedir() throws Exception {
// the provider treats NoLocalRepositoryManagerException as "try the next factory", so a failing
// enhanced factory would silently degrade the whole session to the untracked simple manager
Path missing = basedir.resolve("not-yet-created");
Map<String, LocalRepositoryManagerFactory> factories = new HashMap<>();
factories.put(EnhancedLocalRepositoryManagerFactory.NAME, factory);
factories.put(SimpleLocalRepositoryManagerFactory.NAME, new SimpleLocalRepositoryManagerFactory());
DefaultLocalRepositoryProvider provider = new DefaultLocalRepositoryProvider(factories);

LocalRepositoryManager manager = provider.newLocalRepositoryManager(session, new LocalRepository(missing));

assertInstanceOf(EnhancedLocalRepositoryManager.class, manager);
}
}
Loading