Avoid quadratic XML report writes for ParameterizedClass - #3471
Open
xujiantop-crypto wants to merge 1 commit into
Open
xujiantop-crypto wants to merge 1 commit into
xujiantop-crypto wants to merge 1 commit into
Conversation
Keep parameterized class invocations in one report lifecycle and flush the accumulated test set once the class template completes. Preserve independent lifecycles for ordinary nested classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the Maven Surefire contribution checklist:
Fixes #3439.
JUnit 5.14 ParameterizedClass emits one ClassSource across multiple class-template-invocation containers. RunListenerAdapter previously opened and closed the same test set for every invocation. StatelessXmlReporter then rewrote the accumulated report after each invocation, making the write cost quadratic in the number of invocations.
This keeps the report lifecycle open for a parameterized class branch and flushes the collected source reports once the class template completes. Ordinary nested class containers retain their independent lifecycles.
Validation: