[SUREFIRE-3468] Handle non-reflective JUnit Platform method sources - #3472
Open
xujiantop-crypto wants to merge 1 commit into
Open
xujiantop-crypto wants to merge 1 commit into
xujiantop-crypto wants to merge 1 commit into
Conversation
xujiantop-crypto
force-pushed
the
fix/spock-excluded-groups-discovery
branch
from
September 11, 2026 14:48
cdd0f5e to
52fa764
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The changes are fully reviewed, with no unresolved issues and appropriate regression coverage.
Pull request overview
This pull request fixes SUREFIRE-3468 by handling non-reflective JUnit Platform method sources during category filtering.
Changes:
- Check declaring-class categories before resolving methods.
- Ignore unresolvable method sources safely.
- Add regression coverage for include and exclude filters.
File summaries
| File | Description |
|---|---|
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java |
Adds regression coverage for both category filters. |
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java |
Safely handles non-reflective method sources. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MethodSource#getJavaMethod()before checking the declaring class for JUnit 4 categories.<groups>and<excludedGroups>discovery can complete.Fixes #3468
Verification
<excludedGroups>scenario: fixed build ran 2 tests successfully.