[SUREFIRE-2090] - Xref link to source code with specified line number doesn't work. Missing "L" in anchor - #555
Merged
Conversation
…doesn't work. Missing "L" in anchor
Member
|
@raupachz thanks, good luck for searching next |
|
Resolve #3137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
last December Karl Heinz Marbaise showed me the "up for grabs" JIRA issues. Thanks again Karl Heinz! Unfortunately it took me much longer than expected.
Anyway, here is a tiny contribution on my behalf. This fixes SUREFIRE-2090. The fix was more more less stated in the comments by Michael Osipov. I added the 'L' and updated the test cases in
SurefireReportMojoTest. I also made sure it works in a pet project of mine.Since this is my first contribution to Apache Maven I am unaware if I did everything according to the conventions. I am unsure where to communicate: the dev mailing, JIRA or here at GitHub. I will leave a comment pointing to this PR in the JIRA issue.