Updating commons-lang3 and testng dependencies

[sid-srini]

Updated the following third-party dependency modules:

1. apache commons lang3: from 3.17.0 to 3.19.0
2. testng: from 6.14.3 to 7.11.0

[mbien]

I don't have much experience in the TestNG area so I looked at the classpath changes. TestNGs classpath change looked a bit scary at first but it might be optional deps.

lang3 looks fine:

$ mvn eu.maveniverse.maven.plugins:toolbox:gav-classpath-diff -Dunified -Dgav1=org.apache.commons:commons-lang3:3.17.0 -Dgav2=org.apache.commons:commons-lang3:3.19.0
...
[INFO] --- toolbox:0.15.4:gav-classpath-diff (default-cli) @ standalone-pom ---
[INFO] *** org.apache.commons:commons-lang3:jar 3.17.0 -> 3.19.0

TestNG:

$ mvn eu.maveniverse.maven.plugins:toolbox:gav-classpath-diff -Dunified -Dgav1=org.testng:testng:6.14.3 -Dgav2=org.testng:testng:7.11.0
...
[INFO] --- toolbox:0.15.4:gav-classpath-diff (default-cli) @ standalone-pom ---
[INFO] *** org.testng:testng:jar 6.14.3 -> 7.11.0
[INFO] --- com.beust:jcommander:jar:1.72
[INFO] --- org.apache-extras.beanshell:bsh:jar:2.0b6
[INFO] +++ org.slf4j:slf4j-api:jar:2.0.16
[INFO] +++ org.jcommander:jcommander:jar:1.83
[INFO] +++ org.webjars:jquery:jar:3.7.1
[INFO] +++ com.google.inject:guice:jar:5.1.0
[INFO] +++ javax.inject:javax.inject:jar:1
[INFO] +++ aopalliance:aopalliance:jar:1.0
[INFO] +++ com.google.guava:guava:jar:30.1-jre
[INFO] +++ com.google.guava:failureaccess:jar:1.0.1
[INFO] +++ com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava
[INFO] +++ com.google.code.findbugs:jsr305:jar:3.0.2
[INFO] +++ org.checkerframework:checker-qual:jar:3.5.0
[INFO] +++ com.google.errorprone:error_prone_annotations:jar:2.3.4
[INFO] +++ com.google.j2objc:j2objc-annotations:jar:1.3
[INFO] +++ org.yaml:snakeyaml:jar:2.2

the whole guice branch (+snakeyyaml) seems to be optional:

$ mvn eu.maveniverse.maven.plugins:toolbox:gav-tree -Dgav=org.testng:testng:7.11.0
[INFO] --- toolbox:0.15.4:gav-tree (default-cli) @ standalone-pom ---
[INFO] org.testng:testng:jar:7.11.0 (origin: central)
[INFO] ├─org.slf4j:slf4j-api:jar:2.0.16 [compile] (origin: central)
[INFO] ├─org.jcommander:jcommander:jar:1.83 [compile] (origin: central)
[INFO] ├─org.webjars:jquery:jar:3.7.1 [runtime] (origin: central)
[INFO] ├─com.google.inject:guice:jar:5.1.0 [compile, optional] (origin: central)
[INFO] │ ├─javax.inject:javax.inject:jar:1 [compile, optional] (origin: central)
[INFO] │ ├─aopalliance:aopalliance:jar:1.0 [compile, optional] (origin: central)
[INFO] │ ╰─com.google.guava:guava:jar:30.1-jre [compile, optional] (origin: central)
[INFO] │   ├─com.google.guava:failureaccess:jar:1.0.1 [compile, optional] (origin: central)
[INFO] │   ├─com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava [compile, optional] (origin: central)
[INFO] │   ├─com.google.code.findbugs:jsr305:jar:3.0.2 [compile, optional] (origin: central)
[INFO] │   ├─org.checkerframework:checker-qual:jar:3.5.0 [compile, optional] (origin: central)
[INFO] │   ├─com.google.errorprone:error_prone_annotations:jar:2.3.4 [compile, optional] (origin: central)
[INFO] │   ╰─com.google.j2objc:j2objc-annotations:jar:1.3 [compile, optional] (origin: central)
[INFO] ╰─org.yaml:snakeyaml:jar:2.2 [runtime, optional] (origin: central)

[sid-srini]

Thanks a lot @mbien for running all the CI tests, and, for going through the changes and dependencies.

You are right that the majority of the listed dependencies are optional ones. The libraries included: slf4j and jcommander, were the non-optional ones that are required. Also, the testng jar already contains the jquery js components for the HTML reports it generates.

Additionally, the testng-ant library is now included because it is now a separate library (also mentioned in the commit message of 8169a5c) and is used by NetBeans for running testng via ant.

[sid-srini]

Hi @mbien. Please review this when you get a chance. Thank you.

[sid-srini]

Hi @mbien. I've rebased the commit to the current master which includes the post NB30 updates. Please re-trigger the CI checks and review the PR. Thanks a lot.

[matthiasblaesing]

I think this can be merged, @mbien could I get a second opinion?

[mbien]

wasn't able to fully catch up yet but this looks good to me. Yes feel free to merge.

[matthiasblaesing]

@sid-srini this change most probably broke ant project integration. Please have a look at #9561. The problem is reproducible.