You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is sample fix for #260. There are two issues introduced by #113:
the new datatype field caused test_tpcds_export_matches_expected to fail due to Omni exporter lacks the logic to default is_time: true for temporal-typed fields whose explicit dimension role was unset
the test_osi_roundtrip_up_to_documented_normalizations fails due to non-native datatype property is dropped upon export but the test's normalization helper didn't remove it from the compared semantic model.
Related Issues
Checklist
Specification
Spec changes are included in core-spec/ and follow the existing structure
Spec changes have been discussed on the mailing list or in a linked issue
Breaking changes to the spec are clearly called out in the summary
Ontology
Ontology changes in ontology/ are consistent with spec changes
New or modified terms are defined and documented
Converters
Converter logic in converters/ is updated to reflect spec or ontology changes
New converters include tests under the converter's test directory
Validation
Validation rules in validation/ are updated if the spec changed
New validation cases are covered by tests
Documentation
docs/ is updated to reflect any user-facing changes
New features or behaviors are documented with examples where appropriate
CONTRIBUTING.md is updated if the contribution process changed
Examples
examples/ are added or updated for any new spec constructs or converter support
Tests
All existing tests pass (pytest / CI green)
New functionality is covered by tests
Compliance
ASF license headers are present on all new source files
No third-party dependencies are added without PMC/IPMC approval
Should we also trigger converter-omni-ci when there are changes to core-spec/ or examples/?
For this specific one, I think it should be trigger on python/src/ossie as core-spec/ doesn't directly get used by the converters. Now for examples, not everything uses examples as direct references, thus, I am not sure if that would be a good idea for apply for all (but for sure we can apply for this specific one). However, maybe we should raise those up in a different PR? The original problem with 113 got merged was no CI was ran as it didn't rebase.
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks, and apologies for the churn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is sample fix for #260. There are two issues introduced by #113:
datatypefield causedtest_tpcds_export_matches_expectedto fail due to Omni exporter lacks the logic to defaultis_time: truefor temporal-typed fields whose explicit dimension role was unsettest_osi_roundtrip_up_to_documented_normalizationsfails due to non-nativedatatypeproperty is dropped upon export but the test's normalization helper didn't remove it from the compared semantic model.Related Issues
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance