Skip to content

fix(dbt): resolve SUM_BOOLEAN semantic model for qualified columns - #292

Open
fanruan-tuco wants to merge 2 commits into
apache:mainfrom
fanruan-tuco:fix/265-sum-boolean-dataset-resolution
Open

fix(dbt): resolve SUM_BOOLEAN semantic model for qualified columns#292
fanruan-tuco wants to merge 2 commits into
apache:mainfrom
fanruan-tuco:fix/265-sum-boolean-dataset-resolution

Conversation

@fanruan-tuco

Copy link
Copy Markdown

Summary

Fixes dataset resolution for SUM_BOOLEAN metrics that reference qualified columns. The converter now reads the dataset qualifier from the parsed SQL expression instead of splitting the rendered CASE expression.

Related Issues

Fixes #265

Testing

cd converters/dbt
uv run pytest

Result: 99 passed.

Checklist

Converters

  • Converter logic is updated

Tests

  • All relevant tests pass
  • The fix is covered by a regression test

Compliance

  • No third-party dependencies are added

@jbonofre
jbonofre requested a review from QMalcolm July 30, 2026 06:35
@jbonofre

Copy link
Copy Markdown
Member

@QMalcolm wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

_find_dataset_for_col resolves the wrong semantic_model for SUM_BOOLEAN metrics over qualified columns

2 participants