HDDS-16405. ReplicationManagerReport should not be used for transient state

[sodonnel]

What changes were proposed in this pull request?

In a recent change ReplicationManagerReport gained an extra field to track the end health state of a container when it is processed. While this resulted in a smaller code change, this not how RMReport is supposed to be used and it was intended to have aggregated stats, not per request stats. We already have the ContainerCheckRequest object which has all details of a request and any result can be set in there.

This change removes the transient per container state from RMReport and moves the result into ContainerCheckRequest where it is better suited. It also centralizes the report "increment and sample" so the state and increment are performed together with a single call from the handlers.

Also added a new test in TestContainerCheckRequest to ensure that when calling request.setHealthState() it updates the report and sets the heath result, which avoids having to update all the sets that assert on the report state, as that would have made this change a lot larger.

This change is needed before #11199 can move forward as it starts to build on the pattern added to the report.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-16405

How was this patch tested?

Existing tests and a new unit test.

[Copilot]

🟡 Changes recommended

The moderate, three-vote finding leaves the read-only classification path with stale health state.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

HDDS-16405 moves transient container health state from ReplicationManagerReport into ContainerCheckRequest while preserving aggregate reporting.

Changes:

• Centralizes health-state updates and report sampling.
• Updates replication health handlers to use request state.
• Removes transient report state and adds unit coverage.

File summaries

File	Summary
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestContainerCheckRequest.java	Tests request health-state and report synchronization.
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/health/TestQuasiClosedStuckReplicationCheck.java	Removes obsolete report reset.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ReplicationManager.java	Uses request health state during processing. Moderate finding (3 votes): the read-only path can leave stale health state because the result is not copied back.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/VulnerableUnhealthyReplicasHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/RatisUnhealthyReplicationCheckHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/RatisReplicationCheckHandler.java	Uses centralized request health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/QuasiClosedStuckReplicationCheck.java	Uses centralized request health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/QuasiClosedContainerHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/OpenContainerHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/EmptyContainerHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ECReplicationCheckHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ECMisReplicationCheckHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ClosingContainerHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ClosedWithUnhealthyReplicasHandler.java	Uses request-based health-state updates.
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerCheckRequest.java	Stores per-request health state and updates report statistics.
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java	Removes transient per-container health-state storage.

Review details

• Files reviewed: 16/16 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[F64116045]

Thanks @sodonnel for this refactor. Really appreciate your help with the #11199.
LGTM