PHOENIX-7958 Reduce per-record and per-block copies in replication log writer#2572
Merged
Merged
Conversation
…g writer Switch the record encoder and block writer from java.io.ByteArrayOutputStream to HBase's ByteArrayOutputStream and write directly from the backing buffer via getBuffer()/size() instead of toByteArray(). This eliminates the per-record body copy in LogFileCodec and the per-block copy in LogFileFormatWriter (the latter previously copied the whole ~1MB block even in the uncompressed path). Also hoist the per-record DataOutputStream wrapper to a field. Add an opt-in allocation A/B microbenchmark (testAllocationMicrobenchmark) that drives the full append path and measures heap bytes per record via ThreadMXBean. Measured -22.5% heap/record (3583.5 -> 2776.1 B).
Add testCodecLargeRecordThenSmallReusesBufferCleanly, which encodes a large record then a small one through the same encoder so the reused scratch buffer has grown, then asserts both round-trip with no trailing garbage. This pins the getBuffer()+size() invariant: writing the full backing-array length instead of size() would misframe the stream after the small record. Also correct the testAllocationMicrobenchmark javadoc, which referenced the per-record/per-block toByteArray() calls this change removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.