[SPARK-57692][INFRA] Skip test report when no test results exist#56769
Open
sarutak wants to merge 2 commits into
Open
[SPARK-57692][INFRA] Skip test report when no test results exist#56769sarutak wants to merge 2 commits into
sarutak wants to merge 2 commits into
Conversation
uros-b
reviewed
Jun 25, 2026
dongjoon-hyun
approved these changes
Jun 25, 2026
Member
There was a problem hiding this comment.
+1, LGTM. Yes, the previous attempt was insufficient. Thank you, @sarutak .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds a check in
test_report.ymlto skip the test report publishing step when no test result XML files are found after downloading artifacts.Why are the changes needed?
When a commit only modifies files in the
dev-toolsmodule (e.g.,LICENSE-binary), no build or tests are executed. However, the "Report test results" workflow still triggers on the Build workflow's completion and fails with "No test results found!" because there are no test artifacts to report on.SPARK-55594 (78ab6e2) previously addressed the same "No test results found!" error for the
pages.ymlcase by filtering out that specific workflow path. However, thedev-toolsmodule case was not covered. This PR takes a more general approach by checking for the actual presence of test result files, which handles all cases where tests are legitimately not executed, including any future ones.Note: The existing
pages.ymlfilter in the job'sifcondition is intentionally kept. It avoids spinning up the job entirely for a known no-op case, saving runner resources.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Self review. Also, this will be validated by observing that commits which only modify files in the
dev-toolsmodule (e.g.,LICENSE-binary,README.md,.gitignore) no longer produce a failed "Report test results" check.Was this patch authored or co-authored using generative AI tooling?
Kiro CLI / Claude