Skip to content

Bar chart spilling out past x-axis on both ends #26254

Closed

Description

@sfirke

Superset 3.1.0rc2:

image

How it looks previously in 3.0.0:

image

Here's the chart config in 3.1.0rc2:

image

Again there's a numeric x-axis, maybe broken by #26215 ?

Activity

  1. michael-s-molina commented on Dec 12, 2023

    @michael-s-molina
    Member

    It looks like that's how ECharts displays the bar chart with numerical x-axis when min is defined as dataMin.

    Screenshot 2023-12-12 at 17 27 26

    I searched ECharts docs but I was not able to find a configuration that would fix this. It looks like you need to manually set bounds.

  2. sfirke commented on Dec 12, 2023

    @sfirke
    MemberAuthor

    Thanks for looking into this, I'm sorry to hear there's nothing in ECharts to help with this. This wasn't a problem in 3.0.0 so maybe there's a way forward? It's an unfortunate regression.

    Manually set bounds don't provide a satisfactory experience here. If I set 2017 as my x-min I get weird whitespace and x-min = 2018 gets me the same as the bad chart I posted. 2017.5 looks okay but creates a silly "2017.5" label, and anyway if my data values are subject to change I would have to keep changing the bounds.

    I think my best way forward for now is to cast the x-axis variable to a categorical (varchar). But I would love to see the 3.0.0 behavior return.

  3. michael-s-molina commented on Dec 12, 2023

    @michael-s-molina
    Member

    @villebro do you think there's something we can do here?

    But I would love to see the 3.0.0 behavior return.

    @sfirke This would bring back the bug of treating numerical values as categories.

  4. sfirke commented on Dec 12, 2023

    @sfirke
    MemberAuthor

    @michael-s-molina is that bug documented / can you link to it? 🙏 EDIT: I see the regression you referenced, #26034

  5. michael-s-molina commented on Dec 12, 2023

    @michael-s-molina
    Member
  6. self-assigned this
    on Dec 13, 2023
  7. sfirke commented on Dec 19, 2023

    @sfirke
    MemberAuthor

    This is persisting for me in 3.1.0rc3:
    image

  8. reopened this on Dec 19, 2023
  9. michael-s-molina commented on Dec 19, 2023

    @michael-s-molina
    Member

    @villebro It looks like scale will not be sufficient and we'll need to submit a fix to ECharts to unblock the releases.

  10. villebro commented on Dec 19, 2023

    @villebro
    Member

    @michael-s-molina @sfirke IIUC, the plan was to add a note to UPDATING informing users that Superset won't automatically convert numerical x-axes to categorical, and that they should be manually cast to categorical to get the previous appearance? I feel blocking the release in anticipation of getting this improvement into ECharts first will be excessive. Therefore, if we really do feel like numerical x-axis support is too lacking in the current state, we should probably just roll back to always using categorical x-axis until the upstream change is in place?

  11. sfirke commented on Dec 19, 2023

    @sfirke
    MemberAuthor

    I had mistakenly thought this issue was fixed so thank you for clarifying. As it's not, can we leave it open?

    I agree this should not hold up the release of 3.1.0. If we can't fix this without changes in ECharts then it's a matter of which bug is better to live with, this or #26034. I think we keep this one, because there is the workaround of casting the variable to varchar (which I tested and works). I can cast the variables and replace as users report issues.

    Thank you both for working on this. I noticed that compared to rc2, this only affects an unstacked bar chart with a dimension - when I stack it, it looks good in 3.1.0rc3. So there seems to be have been progress from the screenshots posted above by @michael-s-molina and in 26269 by @villebro showing single bars spilling over the sides.

  12. michael-s-molina commented on Dec 19, 2023

    @michael-s-molina
    Member

    I think we keep this one, because there is the workaround of casting the variable to varchar (which I tested and works). I can cast the variables and replace as users report issues.

    Makes sense.

    As it's not, can we leave it open?

    Yes. The context in this discussion will also be useful for folks when they find this problem.

  13. michael-s-molina commented on Dec 19, 2023

    @michael-s-molina
    Member

    For anyone reading this thread, here's the summary about this issue:

    There's a bug in ECharts when displaying numerical x-axis in bar charts. We'll work with the ECharts team to provide a solution.

    While the solution is not available, you can follow the instructions in UPDATING.md

    #26034: Fixes a problem where numeric x-axes were being treated as categorical values. As a consequence of that, the way labels are displayed might change given that ECharts has a different treatment for numerical and categorical values. To revert to the old behavior, users need to manually convert numerical columns to text so that they are treated as categories. Check #26159 for more details.

    or use the x-axis truncation controls when applicable.

  14. sfirke commented on Jan 15, 2024

    @sfirke
    MemberAuthor

    New fix method: in 3.0.3+ (where this problem first appears), users don't have to manually convert numerical columns to text - there is now a "force categorical" checkbox that instantly applies the fix to a chart 🎉 Implemented in #26404.

  15. 1 remaining item

  16. rumbin commented on May 13, 2024

    @rumbin
    Contributor

    Wouldn't this bring back #26034?

  17. rusackas commented on May 13, 2024

    @rusackas
    Member

    Oh... good question... probably so. :/

  18. rusackas commented on Mar 19, 2025

    @rusackas
    Member

    Is this still happening in 4.1.1?

  19. sfirke commented on Mar 19, 2025

    @sfirke
    MemberAuthor

    Yes, here it is in 4.1.2rc1:

    Image

    The "force categorical" still works as a workaround. I see no action in the linked eCharts issue so it makes sense this persists in Superset.

  20. added
    validation:validatedA committer has validated / submitted the issue or it was reported by multiple users
    and removed on Mar 19, 2025
  21. rusackas commented on Jun 13, 2025

    @rusackas
    Member

    Did 5.0 fix it? 🤞

  22. rusackas commented on Mar 11, 2026

    @rusackas
    Member

    Can anyone verify whether bar charts still spill past the x-axis in Superset 5.0.0? @rusackas was hopeful the 5.0 release might resolve this. Please report back so we can close or continue tracking.

  23. sfirke commented on Mar 12, 2026

    @sfirke
    MemberAuthor

    I can confirm this persists in 6.0.0, if I uncheck Force categorical it spills out on the left exactly as in my screenshot above.

  24. sfirke commented on May 1, 2026

    @sfirke
    MemberAuthor

    After #39141, which first appears in 6.1.0rc3, I am unchecking the "force categorical" chart with a numeric x-axis and the chart still looks good even without that box checked.

    I wonder if we can get rid of the "force categorical" box now - after #39141, is it effectively always checked behind the scenes?

  25. rusackas commented on Jun 13, 2026

    @rusackas
    Member

    Looks like #26269 fixed the bars spilling past the x-axis when it merged. I think we can close this, but not sure if you agree, or also wanna tackle the force categorical thing before closing this out.

  26. rusackas commented on Jun 16, 2026

    @rusackas
    Member

    @sfirke your call on whether or not to close this one, just to @-mention you properly ;)

  27. rusackas commented on Jun 17, 2026

    @rusackas
    Member

    Thinning the herd time! #26269 switched the bar-chart x-axis to scale: true and fixed the spilling, so this looks resolved (enough) to me. Closing, but ping me to reopen if it's still off in a recent version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

validation:validatedA committer has validated / submitted the issue or it was reported by multiple users

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions