Markdown apostrophe (``) use to highlight a keyword not working #32416

Activity

1. dosubot

   added

   dashboard:markdownRelated to the markdown component of the DashboardRelated to the markdown component of the Dashboard

   on Feb 27, 2025
2. dosubot commented on Feb 27, 2025

   

   dosubotBot

   on Feb 27, 2025 – with DosuBot

   More actions

   The error message "This markdown component has an error" is triggered in the Markdown.jsx file when there is an issue with rendering the markdown content. This error handling is implemented in the componentDidCatch method, which displays the error message if the markdown component encounters an error during rendering ^[1].

   In Superset version 5.0.0rc1, there have been recent changes to the markdown rendering logic, including the addition of a remark plugin and improvements to the SafeMarkdown HTML sanitization ^[2][3]. The SafeMarkdown component, which handles markdown rendering, uses the react-markdown library and supports GitHub Flavored Markdown (GFM) through the remark-gfm plugin. It also includes HTML sanitization, which can be customized ^[4].

   The issue with using backticks (``) to highlight a keyword might be related to these recent changes or the configuration of the SafeMarkdown component. You might want to check if the `EscapeMarkdownHtml` feature flag is enabled, as it affects how HTML is handled in markdown ^[4].

   To continue talking to Dosu, mention @dosu.

   ---

   ^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}
3. michael-s-molina

   added this to Apache Superset 5.0.0on Feb 27, 2025
4. michael-s-molina

   moved this to New in Apache Superset 5.0.0on Feb 27, 2025
5. hainenber commented on Feb 28, 2025

   

   hainenber

   on Feb 28, 2025

   Contributor

   More actions

   Pin remark-gfm back to v3 solves the described issue.

   Screen.Recording.2025-02-28.at.12.24.40.mov

   👍React with 👍1Reacted by Evan Rusackas
6. rusackas commented on Feb 28, 2025

   

   rusackas

   on Feb 28, 2025

   Member

   More actions

   I wonder if remark has a fix for this in a newer version?
7. hainenber commented on Mar 1, 2025

   

   hainenber

   on Mar 1, 2025

   Contributor

   More actions

   According to this post, it's a yes but require react-markdown to next major version, which is something we can't do due to the upgrade requires React 18.
8. rusackas

   closed this as completedin #32420on Mar 1, 2025
9. sadpandajoe

   assigned

   hainenber

   on Mar 3, 2025
10. sadpandajoe

    moved this from New to Done in Apache Superset 5.0.0on Mar 3, 2025
11. michael-s-molina

    moved this from Done to Cherried in Apache Superset 5.0.0on Apr 1, 2025
12. sfirke commented on May 16, 2025

    

    sfirke

    on May 16, 2025

    Member

    More actions

    Just deleted an incorrect comment saying I was seeing this in 4.1.2 when I should have said 5.0.0rc2 -- which doesn't add anything to this thread, sorry.
13. rebenitez1802

    added 4 commits that reference this issue on Jan 7, 2026

    test: add comprehensive remark-gfm v3 compatibility regression tests

    ...

    15946de

    test: add comprehensive remark-gfm v3 compatibility regression tests

    ...

    a948f0a

    test: add comprehensive remark-gfm v3 compatibility regression tests

    ...

    a05faf6

    test: add comprehensive remark-gfm v3 compatibility regression tests

    ...

    8ea9a30